Don't download windows-aarch64 binaries on win64 host #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ven on an x86_64 host. Correct this by adding suport for all current rust Tier 1 support platforms: https://doc.rust-lang.org/beta/rustc/platform-support.html#tier-1-with-host-tools
…o CI would fail in the lune case the PR fixes.
ZoteTheMighty
approved these changes
Jul 10, 2023
Contributor
ZoteTheMighty
left a comment
There was a problem hiding this comment.
Looks good, just needs a CI fix to get tests to pass
keep lune on specific version that triggers the original bug. darklua has a newer version since its migration to github, but keeping it on the last version published to gitlab since it's the only regression test for gitlab functionality.
ZoteTheMighty
added a commit
that referenced
this pull request
Jul 18, 2023
Updates snapshot tests, should unblock #71
Contributor
ZoteTheMighty
left a comment
There was a problem hiding this comment.
Hacked on this a bit with my windows machine and I found that a few things aren't working:
luau-lsp is not a rust tool created with clap, so it doesn't have a -V command and errors when you run luau-lsp -V; the e2e test script needs to avoid this or adjust to allow custom version commands.
I made some adjustments to the script in a branch: 7487572
Could you try integrating them and seeing if they work for you locally and/or on CI?
…verify correct download
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where a project with windows-aarch64 assets would download even on an x86_64 host.
Correct this by adding support for all current rust Tier 1 support platforms:
https://doc.rust-lang.org/beta/rustc/platform-support.html#tier-1-with-host-tools