Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Handle rosapi param responses #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Handle rosapi param responses #930

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6cae3f8
Handle rosapi param responses
bjsowa Aug 29, 2025
67b8794
Merge branch 'develop' into feat/check-param-response
bjsowa Sep 4, 2025
9af1fe1
Simplify checking result, call normal callback when failedCallback no…
bjsowa Sep 9, 2025
de31a7f
Update failedCallback description
bjsowa Sep 9, 2025
0e078ff
Merge branch 'develop' into feat/check-param-response
bjsowa Sep 15, 2025
c2d4a2b
Merge branch 'develop' into feat/check-param-response
bjsowa Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions src/core/Param.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ export default class Param {
paramClient.callService(
request,
function (result) {
if (result.successful !== undefined && result.successful === false) {
if (failedCallback) {
failedCallback(result.reason);
}
return;
}
var value = JSON.parse(result.value);
callback(value);
},
Expand Down Expand Up @@ -78,7 +84,21 @@ export default class Param {
value: JSON.stringify(value)
};

paramClient.callService(request, callback, failedCallback);
paramClient.callService(
request,
function (result) {
if (result.successful !== undefined && result.successful === false) {
if (failedCallback) {
failedCallback(result.reason);
}
return;
}
if (callback) {
callback(result);
}
},
failedCallback
);
}
/**
* Delete this parameter on the ROS server.
Expand All @@ -97,6 +117,20 @@ export default class Param {
name: this.name
};

paramClient.callService(request, callback, failedCallback);
paramClient.callService(
request,
function (result) {
if (result.successful !== undefined && result.successful === false) {
if (failedCallback) {
failedCallback(result.reason);
}
return;
}
if (callback) {
callback(result);
}
},
failedCallback
);
}
}