Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test(flaky): ensure agent info is saved before reopening tab #35910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

test(flaky): ensure agent info is saved before reopening tab #35910

merged 2 commits into from
Apr 30, 2025

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Apr 30, 2025 •
edited
Loading

https://rocketchat.atlassian.net/browse/ARCH-1586
https://rocketchat.atlassian.net/browse/FLAKY-1296
https://rocketchat.atlassian.net/browse/FLAKY-1294

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 30, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 922e625

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo added this to the 7.7.0 milestone Apr 30, 2025
@ggazzo ggazzo marked this pull request as ready for review April 30, 2025 02:45
@ggazzo ggazzo requested a review from a team as a code owner April 30, 2025 02:45
@github-actions GitHub Actions
Copy link
Contributor

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35910/

Built to branch gh-pages at 2025-04-30 02:44 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov Codecov
Copy link

codecov bot commented Apr 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.14%. Comparing base (f5a05f3) to head (922e625).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35910      +/-   ##
===========================================
- Coverage    61.15%   61.14%   -0.01%     
===========================================
  Files         3014     3015       +1     
  Lines        71597    71606       +9     
  Branches     16398    16400       +2     
===========================================
+ Hits         43782    43784       +2     
- Misses       24845    24852       +7     
  Partials      2970     2970
Flag Coverage Δ
e2e 57.84% <ø> (-0.02%) ⬇️
e2e-api 35.61% <ø> (+0.01%) ⬆️
unit 75.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo force-pushed the test/omni-agents branch from 581bbd6 to d92db08 Compare April 30, 2025 04:09
@ggazzo ggazzo force-pushed the test/omni-agents branch from 66ada6e to 922e625 Compare April 30, 2025 12:00
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Apr 30, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 30, 2025
@kodiakhq kodiakhq bot merged commit 90b231e into develop Apr 30, 2025
50 checks passed
@kodiakhq kodiakhq bot deleted the test/omni-agents branch April 30, 2025 13:25
ggazzo added a commit that referenced this pull request Apr 30, 2025
@ggazzo
test(flaky): ensure agent info is saved before reopening tab (#35910)
16885a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandernsilva aleksandernsilva aleksandernsilva approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
7.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ggazzo @aleksandernsilva