Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: Adjusted contact review e2e test to prevent possible flaky behavior #35911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

test: Adjusted contact review e2e test to prevent possible flaky behavior #35911

merged 1 commit into from
Apr 30, 2025

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Apr 30, 2025 •
edited by jira bot
Loading

Proposed changes (including videos or screenshots)

Issue(s)

CTZ-97

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 30, 2025 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@aleksandernsilva aleksandernsilva changed the title test: adjusted waitForResponse to prevent possible flaky behavior test: adjusted contact review e2e test to prevent possible flaky behavior Apr 30, 2025
@aleksandernsilva aleksandernsilva changed the title test: adjusted contact review e2e test to prevent possible flaky behavior test: Adjusted contact review e2e test to prevent possible flaky behavior Apr 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35911/

Built to branch gh-pages at 2025-04-30 12:08 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review April 30, 2025 12:09
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner April 30, 2025 12:09
@aleksandernsilva aleksandernsilva added this to the 7.6.0 milestone Apr 30, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.19%. Comparing base (21b219e) to head (6ab09be).
Report is 1 commits behind head on release-7.6.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.6.0   #35911   +/-   ##
==============================================
  Coverage          61.18%   61.19%           
==============================================
  Files               3154     3154           
  Lines              74560    74560           
  Branches           16669    16669           
==============================================
+ Hits               45622    45626    +4     
+ Misses             25832    25829    -3     
+ Partials            3106     3105    -1
Flag Coverage Δ
e2e 58.00% <ø> (+0.01%) ⬆️
unit 74.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo changed the base branch from release-7.6.0 to develop April 30, 2025 13:27
@ggazzo ggazzo requested review from a team as code owners April 30, 2025 13:27
@ggazzo ggazzo changed the base branch from develop to release-7.6.0 April 30, 2025 13:28
@ggazzo ggazzo merged commit 05c57be into release-7.6.0 Apr 30, 2025
51 of 54 checks passed
@ggazzo ggazzo deleted the test/contact-review-flaky-prevention branch April 30, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksandernsilva @ggazzo