apps/meteor/app/api/server/ApiClass.ts (1)

808-810: Fail-fast removal guard: enrich error and confirm startup-crash intent

Throwing during route registration will fail server startup once the planned version is reached. If that’s the goal, keep it—otherwise gate behind an env flag or only enforce in CI/TEST.

Minimal improvement: include method and planned version to aid triage.

-				if (options.deprecation && shouldBreakInVersion(options.deprecation.version)) {
-					throw new Meteor.Error('error-deprecated', `The endpoint ${route} should be removed`);
-				}
+				if (options.deprecation && shouldBreakInVersion(options.deprecation.version)) {
+					const planned = options.deprecation.version;
+					throw new Meteor.Error(
+						'error-deprecated',
+						`The endpoint ${this.getFullRouteName(route, method)} is scheduled for removal in ${planned} and must be removed`,
+						{ endpoint: route, method, planned },
+					);
+				}

If you prefer a softer rollout aligned with the logger’s env knob, consider:

// near other consts
const hardFailDeprecatedRoutes = process.env.ROCKET_CHAT_DEPRECATION_HARD_FAIL !== 'false';

- if (options.deprecation && shouldBreakInVersion(options.deprecation.version)) {
+ if (options.deprecation && shouldBreakInVersion(options.deprecation.version) && hardFailDeprecatedRoutes) {
    // throw...
  }

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

apps/meteor/app/api/server/ApiClass.ts (1)

810-812: LGTM! Consider enhancing the error message with version info.

The pre-registration deprecation guard correctly prevents deprecated endpoints from being registered when they should break in the current version. This fail-fast approach ensures deprecated endpoints are removed before release.

Consider including the deprecation version in the error message for better developer experience:

-				if (options.deprecation && shouldBreakInVersion(options.deprecation.version)) {
-					throw new Meteor.Error('error-deprecated', `The endpoint ${route} should be removed`);
-				}
+				if (options.deprecation && shouldBreakInVersion(options.deprecation.version)) {
+					throw new Meteor.Error('error-deprecated', `The endpoint ${route} should be removed (deprecated since ${options.deprecation.version})`);
+				}

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

apps/meteor/app/api/server/ApiClass.ts (1)

810-812: Good enforcement strategy; consider enriching the error message.

Throwing at registration time (during startup) is the right approach to prevent deprecated endpoints from being used past their removal deadline. This ensures teams can't accidentally deploy code with expired deprecations.

Consider including the deprecation version in the error message for better debugging:

-if (options.deprecation && shouldBreakInVersion(options.deprecation.version)) {
-    throw new Meteor.Error('error-deprecated', `The endpoint ${route} should be removed`);
-}
+if (options.deprecation && shouldBreakInVersion(options.deprecation.version)) {
+    throw new Meteor.Error('error-deprecated', `The endpoint ${route} is deprecated for version ${options.deprecation.version} and should be removed`);
+}

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

apps/meteor/app/api/server/ApiClass.ts (1)

817-819: Enhance error message to include deprecation version for better developer experience.

The deprecation guard correctly prevents registration of endpoints marked for removal in the current version. However, the error message could be more informative by including the deprecation version, helping developers understand why removal is required.

🔎 Suggested enhancement

 if (options.deprecation && shouldBreakInVersion(options.deprecation.version)) {
-    throw new Meteor.Error('error-deprecated', `The endpoint ${route} should be removed`);
+    throw new Meteor.Error('error-deprecated', `The endpoint ${route} was marked for removal in version ${options.deprecation.version} and must be removed`);
 }

Optional efficiency improvement: The rate limiter rules are added (lines 789-795) before this deprecation check. Consider moving this check earlier in the method to avoid unnecessary setup for endpoints that will be rejected. However, this is a minor optimization since the endpoint won't register anyway.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
Repo: RocketChat/Rocket.Chat PR: 0
File: .cursor/rules/playwright.mdc:0-0
Timestamp: 2025-11-24T17:08:17.065Z
Learning: Applies to apps/meteor/tests/e2e/**/*.spec.ts : Ensure tests run reliably in parallel without shared state conflicts

apps/meteor/app/lib/server/lib/deprecationWarningLogger.ts (1)

59-63: Fix TEST_MODE guard ordering in parameter method.

The TEST_MODE guard is placed after compareVersions (line 59), creating inconsistent behavior with all other deprecation logger methods where the guard precedes version comparison. If compareVersions throws when ROCKET_CHAT_DEPRECATION_THROW_ERRORS_FOR_VERSIONS_UNDER is set, the TEST_MODE guard never executes, defeating its purpose.

🔎 Proposed fix to move TEST_MODE guard before compareVersions

         }) ?? `The parameter "${parameter}" in the endpoint "${endpoint}" is deprecated and will be removed on version ${version}`;
-    compareVersions(version, message);
-
     if (process.env.TEST_MODE === 'true') {
         throw new Error(message);
     }
 
+    compareVersions(version, message);
+
     metrics.deprecations.inc({ type: 'parameter-deprecation', kind: 'endpoint', name: endpoint, params: parameter });

apps/meteor/app/api/server/ApiClass.ts (1)

817-819: Consider enhancing the error message with the deprecation version.

The error message could be more helpful by including the deprecation version, making it clearer why the endpoint must be removed.

🔎 Suggested enhancement

 if (options.deprecation && shouldBreakInVersion(options.deprecation.version)) {
-    throw new Meteor.Error('error-deprecated', `The endpoint ${route} should be removed`);
+    throw new Meteor.Error('error-deprecated', `The endpoint ${route} was marked for removal in version ${options.deprecation.version} and must be removed`);
 }

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.