Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore!: Remove deprecated setReaction meteor method #36837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 2 commits into from
Sep 1, 2025
Merged

chore!: Remove deprecated setReaction meteor method #36837

ggazzo merged 2 commits into from
Sep 1, 2025

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Aug 29, 2025 •
edited by atlassian bot
Loading

Proposed changes (including videos or screenshots)

Removes the deprecated setReaction meteor method

Issue(s)

ARCH-1756

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 29, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 4249add

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MartinSchoeler MartinSchoeler added this to the 8.0.0 milestone Aug 29, 2025
@codecov
Copy link

codecov bot commented Aug 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.45%. Comparing base (90b2b1e) to head (4249add).
⚠️ Report is 13 commits behind head on release-8.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-8.0.0   #36837      +/-   ##
=================================================
+ Coverage          66.43%   66.45%   +0.02%     
=================================================
  Files               3280     3277       -3     
  Lines             109711   109604     -107     
  Branches           20870    20859      -11     
=================================================
- Hits               72882    72833      -49     
+ Misses             34167    34110      -57     
+ Partials            2662     2661       -1
Flag Coverage Δ
e2e 57.83% <ø> (-0.02%) ⬇️
unit 71.59% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review September 1, 2025 12:36
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Sep 1, 2025
@ggazzo ggazzo merged commit d3e2587 into release-8.0.0 Sep 1, 2025
65 of 67 checks passed
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 1, 2025
@ggazzo ggazzo deleted the remove/setReaction branch September 1, 2025 16:21
ggazzo pushed a commit that referenced this pull request Sep 4, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
22d2853
ggazzo pushed a commit that referenced this pull request Sep 4, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
8c770bd
ggazzo pushed a commit that referenced this pull request Sep 4, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
e6f636e
ggazzo pushed a commit that referenced this pull request Sep 4, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
799afcb
ggazzo pushed a commit that referenced this pull request Sep 30, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
ceaf8dd
ggazzo pushed a commit that referenced this pull request Oct 3, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
3c67950
ggazzo pushed a commit that referenced this pull request Oct 31, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
34b1a43
ggazzo pushed a commit that referenced this pull request Oct 31, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
229d905
ggazzo pushed a commit that referenced this pull request Nov 4, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
f5fa12e
ggazzo pushed a commit that referenced this pull request Nov 5, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
bad4f6a
ggazzo pushed a commit that referenced this pull request Nov 5, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
fd4df44
ggazzo pushed a commit that referenced this pull request Nov 5, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
3ae6bab
ggazzo pushed a commit that referenced this pull request Nov 6, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
9080010
ggazzo pushed a commit that referenced this pull request Nov 12, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
87298c6
ggazzo pushed a commit that referenced this pull request Nov 12, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
0e893ca
ggazzo pushed a commit that referenced this pull request Nov 13, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
f101e19
ggazzo pushed a commit that referenced this pull request Nov 18, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
af76124
ggazzo pushed a commit that referenced this pull request Dec 2, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
87ea593
ggazzo pushed a commit that referenced this pull request Dec 9, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
2bb67cb
ggazzo pushed a commit that referenced this pull request Dec 10, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
7ce2327
ggazzo pushed a commit that referenced this pull request Dec 15, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
dc06427
ggazzo pushed a commit that referenced this pull request Dec 17, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
0e3ae3e
ggazzo pushed a commit that referenced this pull request Dec 17, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
146a7ad
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
c35b5ca
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
21d7e78
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
9bd8533
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
be78ae9
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
e0df6b6
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
13e9466
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
61a72f6
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
3520932
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
@MartinSchoeler @ggazzo
chore!: Remove deprecated setReaction meteor method (#36837)
5f443d7
dougfabris pushed a commit that referenced this pull request Dec 20, 2025
@MartinSchoeler @dougfabris
chore!: Remove deprecated setReaction meteor method (#36837)
2b78c04
@rocketchat-github-ci rocketchat-github-ci mentioned this pull request Dec 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@MartinSchoeler @ggazzo