Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore!: Remove GET method from /api/v1/apps #36907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tassoevan merged 3 commits into from
Sep 15, 2025
Merged

chore!: Remove GET method from /api/v1/apps #36907

tassoevan merged 3 commits into from
Sep 15, 2025

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Sep 10, 2025 •
edited by atlassian bot
Loading

Proposed changes (including videos or screenshots)

Removes the deprecated GET Method from /api/v1/apps

Issue(s)

ARCH-1765

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 10, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: bafcae9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/rest-typings Major
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/http-router Patch
@rocket.chat/models Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/livechat Patch
@rocket.chat/mock-providers Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/core-typings Major
@rocket.chat/apps Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 10, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove/communication-rest-ts

Comment @coderabbitai help to get the list of available commands and usage tips.

@MartinSchoeler MartinSchoeler added this to the 8.0.0 milestone Sep 10, 2025
@codecov
Copy link

codecov bot commented Sep 10, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.36%. Comparing base (712e2f3) to head (bafcae9).
⚠️ Report is 6 commits behind head on release-8.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-8.0.0   #36907      +/-   ##
=================================================
- Coverage          66.37%   66.36%   -0.01%     
=================================================
  Files               3312     3312              
  Lines             111671   111670       -1     
  Branches           20940    20912      -28     
=================================================
- Hits               74121    74111      -10     
- Misses             34872    34882      +10     
+ Partials            2678     2677       -1
Flag Coverage Δ
e2e 58.24% <50.00%> (+<0.01%) ⬆️
unit 70.85% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review September 11, 2025 14:14
@MartinSchoeler MartinSchoeler requested review from a team as code owners September 11, 2025 14:14
juliajforesti
juliajforesti approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@juliajforesti juliajforesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juliajforesti juliajforesti added the stat: QA assured Means it has been tested and approved by a company insider label Sep 11, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 11, 2025
@tassoevan tassoevan merged commit 31fd755 into release-8.0.0 Sep 15, 2025
41 checks passed
@tassoevan tassoevan deleted the remove/communication-rest-ts branch September 15, 2025 14:21
ggazzo pushed a commit that referenced this pull request Sep 30, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
74f8e07
ggazzo pushed a commit that referenced this pull request Oct 3, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
f8be6c7
ggazzo pushed a commit that referenced this pull request Oct 31, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
c4449f2
ggazzo pushed a commit that referenced this pull request Oct 31, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
d01b416
ggazzo pushed a commit that referenced this pull request Oct 31, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
7df0d96
ggazzo pushed a commit that referenced this pull request Nov 4, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
bcb5595
ggazzo pushed a commit that referenced this pull request Nov 5, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
1f85d64
ggazzo pushed a commit that referenced this pull request Nov 5, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
fde6f14
ggazzo pushed a commit that referenced this pull request Nov 5, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
1c74be1
ggazzo pushed a commit that referenced this pull request Nov 6, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
55673bd
ggazzo pushed a commit that referenced this pull request Nov 12, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
c671384
ggazzo pushed a commit that referenced this pull request Nov 12, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
f14845e
ggazzo pushed a commit that referenced this pull request Nov 13, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
1a09974
ggazzo pushed a commit that referenced this pull request Nov 18, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
ba7e8ac
ggazzo pushed a commit that referenced this pull request Dec 2, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
8510dd9
ggazzo pushed a commit that referenced this pull request Dec 9, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
3a7b6bf
ggazzo pushed a commit that referenced this pull request Dec 10, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
b3bcd1f
ggazzo pushed a commit that referenced this pull request Dec 15, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
0a13698
ggazzo pushed a commit that referenced this pull request Dec 17, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
0356687
ggazzo pushed a commit that referenced this pull request Dec 17, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
0629824
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
c903940
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
b888d60
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
183b1aa
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
cb3618b
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
0af00d9
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
256b99f
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
0be2abb
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
1ba79c5
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
@MartinSchoeler @ggazzo
chore!: Remove GET method from /api/v1/apps (#36907)
5ac1863
dougfabris pushed a commit that referenced this pull request Dec 20, 2025
@MartinSchoeler @dougfabris
chore!: Remove GET method from /api/v1/apps (#36907)
354eca4
@rocketchat-github-ci rocketchat-github-ci mentioned this pull request Dec 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d-gubert d-gubert d-gubert approved these changes

@tassoevan tassoevan tassoevan approved these changes

@juliajforesti juliajforesti juliajforesti approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@MartinSchoeler @d-gubert @tassoevan @juliajforesti