Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore!: Remove livechat:resumeOnHold method #36908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 2 commits into from
Sep 11, 2025
Merged

chore!: Remove livechat:resumeOnHold method #36908

kodiakhq merged 2 commits into from
Sep 11, 2025
+6 −94

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Sep 10, 2025 •
edited by atlassian bot
Loading

Proposed changes (including videos or screenshots)

Removes the deprecated livechat:resumeOnHold method

Issue(s)

ARCH-1802

Steps to test or reproduce

Further comments

@MartinSchoeler MartinSchoeler added this to the 8.0.0 milestone Sep 10, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 10, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 1d20aa9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 10, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove/livechat-resumeOnHold

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Sep 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.37%. Comparing base (712e2f3) to head (1d20aa9).
⚠️ Report is 1 commits behind head on release-8.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-8.0.0   #36908      +/-   ##
=================================================
- Coverage          66.37%   66.37%   -0.01%     
=================================================
  Files               3312     3312              
  Lines             111671   111671              
  Branches           20940    20939       -1     
=================================================
- Hits               74121    74120       -1     
- Misses             34872    34877       +5     
+ Partials            2678     2674       -4
Flag Coverage Δ
e2e 58.25% <ø> (+0.01%) ⬆️
unit 70.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review September 11, 2025 12:44
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner September 11, 2025 12:44
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Sep 11, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 11, 2025
@kodiakhq kodiakhq bot merged commit 7e49860 into release-8.0.0 Sep 11, 2025
95 of 99 checks passed
@kodiakhq kodiakhq bot deleted the remove/livechat-resumeOnHold branch September 11, 2025 15:19
ggazzo pushed a commit that referenced this pull request Sep 30, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
88077aa
ggazzo pushed a commit that referenced this pull request Oct 3, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
7deb6d1
ggazzo pushed a commit that referenced this pull request Oct 31, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
b0fcd26
ggazzo pushed a commit that referenced this pull request Oct 31, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
203655b
ggazzo pushed a commit that referenced this pull request Nov 4, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
4728150
ggazzo pushed a commit that referenced this pull request Nov 5, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
ed35d30
ggazzo pushed a commit that referenced this pull request Nov 5, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
4d893de
ggazzo pushed a commit that referenced this pull request Nov 5, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
d96e1c2
ggazzo pushed a commit that referenced this pull request Nov 6, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
d2eeeef
ggazzo pushed a commit that referenced this pull request Nov 12, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
a3011bb
ggazzo pushed a commit that referenced this pull request Nov 12, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
a6f3b63
ggazzo pushed a commit that referenced this pull request Nov 13, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
bcbc92a
ggazzo pushed a commit that referenced this pull request Nov 18, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
8232742
ggazzo pushed a commit that referenced this pull request Dec 2, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
cabd693
ggazzo pushed a commit that referenced this pull request Dec 9, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
1ebb170
ggazzo pushed a commit that referenced this pull request Dec 10, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
2e20656
ggazzo pushed a commit that referenced this pull request Dec 15, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
b6d7aef
ggazzo pushed a commit that referenced this pull request Dec 17, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
ae6c675
ggazzo pushed a commit that referenced this pull request Dec 17, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
d903854
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
cbf7c85
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
20767f0
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
dd585b4
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
461f767
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
256b1e7
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
b9c75ba
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
f60ec52
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
dd01995
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
@MartinSchoeler @ggazzo
chore!: Remove livechat:resumeOnHold method (#36908)
b7a3c1b
dougfabris pushed a commit that referenced this pull request Dec 20, 2025
@MartinSchoeler @dougfabris
chore!: Remove livechat:resumeOnHold method (#36908)
2fed3ba
@rocketchat-github-ci rocketchat-github-ci mentioned this pull request Dec 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KevLehman KevLehman KevLehman approved these changes

@juliajforesti juliajforesti juliajforesti approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@MartinSchoeler @KevLehman @juliajforesti