Codestin Search App

nazabucciarelli · 2026-03-02T21:25:47Z

Proposed changes (including videos or screenshots)

No functional changes are expected along with this PR. This is a small refactor to keep our code better organized regarding custom-sounds API.

Issue(s)

CORE-1825 Refactor: Move Custom Sounds list query validation to @rocket.chat/rest-typings

Steps to test or reproduce

CI Tests should be an enough check that this doesn't break anything, but to be positive we can run the project and test that in Workspace -> Sounds the custom sounds are listed as expected.

Further comments

Summary by CodeRabbit

Refactor
- Consolidated validation logic for custom sounds list endpoint by moving shared validation definitions to a centralized package. No changes to existing functionality or user-facing behavior.

…ings package

dionisio-bot · 2026-03-02T21:25:51Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is missing the 'stat: QA assured' label
This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2026-03-02T21:25:55Z

⚠️ No Changeset found

Latest commit: 6303215

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-03-02T21:25:58Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2c23512 and 6303215.

📒 Files selected for processing (2)

apps/meteor/app/api/server/v1/custom-sounds.ts
packages/rest-typings/src/v1/customSounds.ts

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: cubic · AI code reviewer

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

packages/rest-typings/src/v1/customSounds.ts
apps/meteor/app/api/server/v1/custom-sounds.ts

🧠 Learnings (7)

📓 Common learnings

Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 38974
File: apps/meteor/app/api/server/v1/im.ts:220-221
Timestamp: 2026-02-24T19:09:09.561Z
Learning: In RocketChat/Rocket.Chat OpenAPI migration PRs for apps/meteor/app/api/server/v1 endpoints, maintainers prefer to avoid any logic changes; style-only cleanups (like removing inline comments) may be deferred to follow-ups to keep scope tight.

Learnt from: ggazzo
Repo: RocketChat/Rocket.Chat PR: 35995
File: apps/meteor/app/api/server/v1/rooms.ts:1107-1112
Timestamp: 2026-02-23T17:53:18.785Z
Learning: In Rocket.Chat PR reviews, maintain strict scope boundaries—when a PR is focused on a specific endpoint (e.g., rooms.favorite), avoid reviewing or suggesting changes to other endpoints that were incidentally refactored (e.g., rooms.invite) unless explicitly requested by maintainers.

Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 0
File: :0-0
Timestamp: 2026-02-24T19:05:56.710Z
Learning: Rocket.Chat repo context: When a workspace manifest on develop already pins a dependency version (e.g., packages/web-ui-registration → "rocket.chat/ui-contexts": "27.0.1"), a lockfile change in a feature PR that upgrades only that dependency’s resolution is considered a manifest-driven sync and can be kept, preferably as a small "chore: sync yarn.lock with manifests" commit.

📚 Learning: 2026-02-26T19:25:44.063Z

Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.

Applied to files:

packages/rest-typings/src/v1/customSounds.ts
apps/meteor/app/api/server/v1/custom-sounds.ts

📚 Learning: 2026-02-26T19:25:44.063Z

Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.

Applied to files:

packages/rest-typings/src/v1/customSounds.ts
apps/meteor/app/api/server/v1/custom-sounds.ts

📚 Learning: 2026-02-24T19:09:01.522Z

Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 38974
File: apps/meteor/app/api/server/v1/im.ts:220-221
Timestamp: 2026-02-24T19:09:01.522Z
Learning: In Rocket.Chat OpenAPI migration PRs for endpoints under apps/meteor/app/api/server/v1, avoid introducing logic changes. Only perform scope-tight changes that preserve behavior; style-only cleanups (e.g., removing inline comments) may be deferred to follow-ups to keep the migration PR focused.

Applied to files:

apps/meteor/app/api/server/v1/custom-sounds.ts

📚 Learning: 2026-02-25T20:10:16.987Z

Learnt from: ahmed-n-abdeltwab
Repo: RocketChat/Rocket.Chat PR: 38913
File: packages/ddp-client/src/legacy/types/SDKLegacy.ts:34-34
Timestamp: 2026-02-25T20:10:16.987Z
Learning: In the RocketChat/Rocket.Chat monorepo, packages/ddp-client and apps/meteor do not use TypeScript project references. Module augmentations in apps/meteor (e.g., declare module 'rocket.chat/rest-typings') are not visible when compiling packages/ddp-client in isolation, which is why legacy SDK methods that depend on OperationResult types for OpenAPI-migrated endpoints must remain commented out.

Applied to files:

apps/meteor/app/api/server/v1/custom-sounds.ts

📚 Learning: 2026-01-17T01:51:47.764Z

Learnt from: tassoevan
Repo: RocketChat/Rocket.Chat PR: 38219
File: packages/core-typings/src/cloud/Announcement.ts:5-6
Timestamp: 2026-01-17T01:51:47.764Z
Learning: In packages/core-typings/src/cloud/Announcement.ts, the AnnouncementSchema.createdBy field intentionally overrides IBannerSchema.createdBy (object with _id and optional username) with a string enum ['cloud', 'system'] to match existing runtime behavior. This is documented as technical debt with a FIXME comment at apps/meteor/app/cloud/server/functions/syncWorkspace/handleCommsSync.ts:53 and should not be flagged as an error until the runtime behavior is corrected.

Applied to files:

apps/meteor/app/api/server/v1/custom-sounds.ts

📚 Learning: 2026-02-23T17:53:06.802Z

Learnt from: ggazzo
Repo: RocketChat/Rocket.Chat PR: 35995
File: apps/meteor/app/api/server/v1/rooms.ts:1107-1112
Timestamp: 2026-02-23T17:53:06.802Z
Learning: During PR reviews that touch endpoint files under apps/meteor/app/api/server/v1, enforce strict scope: if a PR targets a specific endpoint (e.g., rooms.favorite), do not propose changes to unrelated endpoints (e.g., rooms.invite) unless maintainers explicitly request them. Focus feedback on the touched endpoint's behavior, API surface, and related tests; avoid broad cross-endpoint changes in the same PR unless requested.

Applied to files:

apps/meteor/app/api/server/v1/custom-sounds.ts

🔇 Additional comments (3)

packages/rest-typings/src/v1/customSounds.ts (2)

4-4: Type-only import is correctly used.

Using import { type PaginatedRequest } keeps the refactor type-safe without adding runtime import overhead.

22-52: Schema extraction is clean and behavior-preserving.

CustomSoundsList + CustomSoundsListSchema and isCustomSoundsListProps are well-scoped and match the intended centralized REST contract pattern for this endpoint.

apps/meteor/app/api/server/v1/custom-sounds.ts (1)

3-6: Import migration is correctly wired to shared typings.

Switching to isCustomSoundsListProps from @rocket.chat/rest-typings keeps the endpoint aligned with centralized contracts while preserving runtime behavior.

Based on learnings: In RocketChat OpenAPI migration PRs for endpoints under apps/meteor/app/api/server/v1, avoid introducing logic changes and keep scope-tight behavior-preserving refactors.

Walkthrough

This change relocates the Custom Sounds list query validation schema from the server API implementation to the centralized @rocket.chat/rest-typings package, consolidating request validation definitions in a single location.

Changes

Cohort / File(s)	Summary
Validation Schema Extraction `apps/meteor/app/api/server/v1/custom-sounds.ts`, `packages/rest-typings/src/v1/customSounds.ts`	Moved CustomSoundsList type, CustomSoundsListSchema definition, and isCustomSoundsListProps validator from server API to rest-typings package. Updated imports in custom-sounds.ts to use the external validator instead of local definition.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

type: chore

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main refactoring: moving custom sounds list query validation schema from REST API to rest-typings package.
Linked Issues check	✅ Passed	The changes fully implement CORE-1825 requirements: moved isCustomSoundsListProps and CustomSoundsList to rest-typings, removed local definitions, and updated imports accordingly.
Out of Scope Changes check	✅ Passed	All changes are directly aligned with CORE-1825 objectives; no unrelated modifications or scope creep detected.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-03-02T21:46:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.89%. Comparing base (2c23512) to head (6303215).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #39263      +/-   ##
===========================================
+ Coverage    70.85%   70.89%   +0.04%     
===========================================
  Files         3208     3208              
  Lines       113426   113426              
  Branches     20530    20530              
===========================================
+ Hits         80368    80416      +48     
+ Misses       31013    30960      -53     
- Partials      2045     2050       +5

Flag	Coverage Δ
e2e	`60.37% <ø> (+0.01%)`	⬆️
e2e-api	`48.81% <ø> (+0.98%)`	⬆️
unit	`71.58% <ø> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cubic-dev-ai

No issues found across 2 files

refactor: move custom sounds list query validation schema to rest-typ…

6303215

…ings package

nazabucciarelli marked this pull request as ready for review March 3, 2026 00:58

nazabucciarelli requested review from a team as code owners March 3, 2026 00:58

cubic-dev-ai bot reviewed Mar 3, 2026

View reviewed changes

coderabbitai bot added the type: chore label Mar 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: move custom sounds list query validation schema to rest-typings package#39263

refactor: move custom sounds list query validation schema to rest-typings package#39263
nazabucciarelli wants to merge 1 commit intodevelopfrom
refactor/custom-sounds-list-query-validation

nazabucciarelli commented Mar 2, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

dionisio-bot bot commented Mar 2, 2026

Uh oh!

changeset-bot bot commented Mar 2, 2026

Uh oh!

coderabbitai bot commented Mar 2, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 2, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

nazabucciarelli commented Mar 2, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

dionisio-bot bot commented Mar 2, 2026

Uh oh!

changeset-bot bot commented Mar 2, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

Uh oh!

codecov bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

nazabucciarelli commented Mar 2, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 2, 2026 •

edited

Loading

codecov bot commented Mar 2, 2026 •

edited

Loading