refactor: Use RequiredField utility for username enforcement in API endpoint context type#39306
Merged
ggazzo merged 2 commits intochore/username-apifrom Mar 3, 2026
Merged
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
…s in definition.ts Co-authored-by: ggazzo <[email protected]>
Copilot
AI
changed the title
[WIP] Update stacked PR to enforce username in endpoint context
refactor: Use Mar 3, 2026
RequiredField utility for username enforcement in API endpoint context type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second conditional user type block in
definition.tswas still using the verboseOmit<IUser, 'username'> & Required<Pick<IUser, 'username'>>pattern instead of theRequiredFieldutility already imported and applied elsewhere in the same file.Changes
apps/meteor/app/api/server/definition.ts: ReplaceOmit<IUser, 'username'> & Required<Pick<IUser, 'username'>>withRequiredField<IUser, 'username'>at both occurrences in theTOptions['authRequired']conditional type block🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.