Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Use HeaderTitle on RoomHeader #6255 #6257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

JASIM0021
Copy link
Contributor

Proposed changes

The RoomHeader component is currently implementing its own HeaderTitle, but it should be using CustomHeader/components/HeaderTitle for consistency and maintainability.

Additionally, HeaderTitle needs to support an onPress event, which requires using PlatformPressable, similar to HeaderButtons. This update ensures a unified approach to handling press events within the header components.

Issue(s)

#6255

How to test or reproduce

Navigate to a screen that displays the RoomHeader.

Ensure that the title now comes from CustomHeader/components/HeaderTitle.

Test that the title responds correctly to press events using PlatformPressable.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added the necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

This change improves code reuse and ensures consistency across header components. Using CustomHeader/components/HeaderTitle aligns RoomHeader with other parts of the app, reducing duplication. Let me know if any additional adjustments are needed! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant