feat: Use HeaderTitle on RoomHeader#6259
Closed
JASIM0021 wants to merge 0 commit intoRocketChat:developfrom
Closed
feat: Use HeaderTitle on RoomHeader#6259JASIM0021 wants to merge 0 commit intoRocketChat:developfrom
JASIM0021 wants to merge 0 commit intoRocketChat:developfrom
Conversation
Contributor
Author
|
Please review the pull request and merge it. |
Rohit3523
reviewed
Mar 23, 2025
Rohit3523
reviewed
Mar 23, 2025
Member
|
This PR get changes of markdown fix, Please remove them. |
Rohit3523
reviewed
Mar 23, 2025
Rohit3523
reviewed
Mar 23, 2025
diegolmello
requested changes
Mar 24, 2025
Member
diegolmello
left a comment
There was a problem hiding this comment.
Can you add before/after screenshots of this change on your PR description?
We're aiming for a pixel perfect switch.
Contributor
Author
diegolmello
requested changes
Mar 24, 2025
diegolmello
requested changes
Mar 25, 2025
Member
diegolmello
left a comment
There was a problem hiding this comment.
Still missing screenshots (not stories) on your PR description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Proposed changes
The RoomHeader component is currently implementing its own HeaderTitle, but it should be using CustomHeader/components/HeaderTitle for consistency and maintainability.
Additionally, HeaderTitle needs to support an onPress event, which requires using PlatformPressable, similar to HeaderButtons. This update ensures a unified approach to handling press events within the header components.
Issue(s)
#6255
How to test or reproduce
Navigate to a screen that displays the RoomHeader.
Ensure that the title now comes from CustomHeader/components/HeaderTitle.
Test that the title responds correctly to press events using PlatformPressable.
Screenshots
Types of changes
Checklist
Further comments
This change improves code reuse and ensures consistency across header components. Using CustomHeader/components/HeaderTitle aligns RoomHeader with other parts of the app, reducing duplication. Let me know if any additional adjustments are needed! 🚀