Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Use HeaderTitle on RoomHeader #6259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
Open

feat: Use HeaderTitle on RoomHeader #6259

wants to merge 22 commits into from

Conversation

JASIM0021
Copy link
Contributor

Proposed changes

The RoomHeader component is currently implementing its own HeaderTitle, but it should be using CustomHeader/components/HeaderTitle for consistency and maintainability.

Additionally, HeaderTitle needs to support an onPress event, which requires using PlatformPressable, similar to HeaderButtons. This update ensures a unified approach to handling press events within the header components.

Issue(s)

#6255

How to test or reproduce

Navigate to a screen that displays the RoomHeader.

Ensure that the title now comes from CustomHeader/components/HeaderTitle.

Test that the title responds correctly to press events using PlatformPressable.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added the necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

This change improves code reuse and ensures consistency across header components. Using CustomHeader/components/HeaderTitle aligns RoomHeader with other parts of the app, reducing duplication. Let me know if any additional adjustments are needed! 🚀

@JASIM0021
Copy link
Contributor Author

Please review the pull request and merge it.

@Rohit3523
Copy link
Contributor

This PR get changes of markdown fix, Please remove them.

diegolmello
diegolmello requested changes Mar 24, 2025
View reviewed changes
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add before/after screenshots of this change on your PR description?
We're aiming for a pixel perfect switch.

@JASIM0021
Copy link
Contributor Author

Before
Simulator Screenshot - iPhone 16 Pro - 2025-03-24 at 22 46 30

After
Simulator Screenshot - iPhone 16 Pro - 2025-03-24 at 22 56 13

@JASIM0021 JASIM0021 requested a review from diegolmello March 24, 2025 17:50
@JASIM0021 JASIM0021 requested a review from diegolmello March 25, 2025 03:11
diegolmello
diegolmello requested changes Mar 25, 2025
View reviewed changes
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing screenshots (not stories) on your PR description.

@JASIM0021 JASIM0021 requested a review from diegolmello March 25, 2025 17:15
@JASIM0021 JASIM0021 requested a review from Rohit3523 April 27, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolmello diegolmello Awaiting requested review from diegolmello

@Rohit3523 Rohit3523 Awaiting requested review from Rohit3523

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JASIM0021 @Rohit3523 @diegolmello