-
Notifications
You must be signed in to change notification settings - Fork 1.3k
regression: Navigation issues after upgrading to react-navigation 7 #6492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2c4b19e
to
6abe582
Compare
…Rocket.Chat.ReactNative into fix.react-navigation-7-fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Android Build Available Rocket.Chat Experimental 4.63.0.87758 Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNQz3pf48W8HBzOt5uTC-XQtRFmMFcsfzjop7ojM4t2cZ5jhJ0enRftASc13XbrDW0mLjU5a-vzYthMxUbrh |
Android Build Available Rocket.Chat Experimental 4.63.0. |
It's working 🫣 Yeahhhh 😍 |
Android Build Available Rocket.Chat 4.63.0.87758 Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNSiyX8_3jmwkI6TFYOwA478K5ic6GN0nToGYe9xJmLKNDDh9Kb6zm4Z0qxn4OQhMMxe2Bnv_u4yhrbMUsWS |
iOS Build Available Rocket.Chat Experimental 4.63.0.87758 |
Android Build Available Rocket.Chat 4.63.0. |
Proposed changes
Since we upgraded to react-navigation 7 and it had several breaking changes, tablets weren't working properly and sometimes RoomView could be instantiated more than once on mobile, which is wrong.
I've reviewed all navigation changes to RoomView and leaving RoomView and made the necessary changes to cover both mobile and tablet.
Here are the events I reviewed:
It also removes the window logic from
subscriptions/room
mentioned in #6057.It's a potential fix for it.
It may need a separate PR, but it's ok to merge it here until we decide otherwise.
Issue(s)
Relates to #6057
https://rocketchat.atlassian.net/browse/NATIVE-936
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments