Add exponential backoff for mid-stream retry failures #8888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extend StackItem with retryAttempt counter - Extract shared backoffAndAnnounce helper for consistent retry UX - Apply exponential backoff to mid-stream failures when auto-approval enabled - Add debug throw for testing mid-stream retry path
Contributor
|
Review Complete ✅ No issues found. The implementation correctly adds exponential backoff for mid-stream retry failures. |
Allows early exit from exponential backoff if task is cancelled during delay
mrubens
approved these changes
Oct 28, 2025
2.send bad message (you can give provider some error apikey) 3.click 
4.The program is stuck in a loop // note that this api_req_failed ask is unique in that we only present this option if the api hasn't streamed any content yet (ie it fails on the first chunk due), as it would allow them to hit a retry button. However if the api failed mid-stream, it could be in any arbitrary state where some tools may have executed, so that error is handled differently and requires cancelling the task entirely.
if (autoApprovalEnabled && alwaysApproveResubmit) {😱😱loop😱😱
let errorMsg
if (error.error?.metadata?.raw) {
errorMsg = JSON.stringify(error.error.metadata.raw, null, 2)
} else if (error.message) {
errorMsg = error.message
} else {
errorMsg = "Unknown error"
}
// Apply shared exponential backoff and countdown UX
await this.backoffAndAnnounce(retryAttempt, error, errorMsg) 😱😱loop😱😱
// Delegate generator output from the recursive call with
// incremented retry count.
yield* this.attemptApiRequest(retryAttempt + 1) 😱😱loop😱😱
return
} else { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes immediate retry loop for mid-stream failures by applying the same exponential backoff logic used for first-chunk errors.
Changes:
Previously, mid-stream failures would retry immediately without any delay, potentially overwhelming failing APIs. Now they follow the same rate-limiting policy as first-chunk failures.
Important
Adds exponential backoff for mid-stream retry failures in
Task.ts, aligning retry behavior with first-chunk errors.recursivelyMakeClineRequests()inTask.ts, aligning with first-chunk error handling.retryAttemptcounter toStackItemfor tracking retry attempts.autoApprovalEnabledandalwaysApproveResubmitare true.backoffAndAnnounce()for shared backoff logic, reducing code duplication.This description was created by
for 45ed85d. You can customize this summary. It will automatically update as commits are pushed.