fix: remove NativeArgsFor<TName> type override from search_replace case#9922
Closed
roomote[bot] wants to merge 3 commits intomainfrom
Closed
fix: remove NativeArgsFor<TName> type override from search_replace case#9922roomote[bot] wants to merge 3 commits intomainfrom
roomote[bot] wants to merge 3 commits intomainfrom
Conversation
Contributor
Author
Review complete. All issues have been addressed.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
dcbartlett
suggested changes
Dec 8, 2025
dcbartlett
approved these changes
Dec 8, 2025
Contributor
Author
The requested change has already been applied in this PR. Looking at the current state of nativeArgs = {
file_path: args.file_path,
old_string: args.old_string,
new_string: args.new_string,
}This was done in commit e327aeb. No additional changes needed. |
mrubens
approved these changes
Dec 8, 2025
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Contributor
|
No effective changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9918
Removes the
as NativeArgsFor<TName>type override from thesearch_replacecase in NativeToolCallParser.ts as requested in the PR review comment.Changed the type assertion to
as anyto maintain compilation while removing the generic type override. The broader nativeArgs typing issues will be addressed separately as noted by the reviewer.Important
Change type assertion from
as NativeArgsFor<TName>toas anyinsearch_replacecase inNativeToolCallParser.ts.NativeToolCallParser.ts, change type assertion fromas NativeArgsFor<TName>toas anyin thesearch_replacecase.This description was created by
for 7537382. You can customize this summary. It will automatically update as commits are pushed.