sha1+sha2: make aarch64 CPU feature detection OS-independent#276
Merged
tarcieri merged 1 commit intoMay 15, 2021
Merged
Conversation
`cpufeatures` v0.1.4 can build on any `aarch64` target, not just Linux/macOS ones: RustCrypto/utils#40 This PR bumps the minimum `cpufeatures` requirement to v0.1.4 and removes the OS-specifisms on `aarch64` targets.
b82d1c8 to
656087c
Compare
Member
|
nice |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cpufeaturesv0.1.4 can build on anyaarch64target, not just Linux/macOS ones:RustCrypto/utils#40
This PR bumps the minimum
cpufeaturesrequirement to v0.1.4 and removes the OS-specifisms onaarch64targets.On platforms other than Linux/macOS, CPU features are always detected as
falseunless the correspondingtarget_features have been enabled viaRUSTFLAGS. But in the future, we can add new platform support tocpufeatureswithout changing all of its downstream consumers.