Thanks to visit codestin.com
Credit goes to github.com

Skip to content

sha1: pass block slices to sha1_asm + remove cfg toggle for constants#285

Closed
tlercher wants to merge 1 commit into
RustCrypto:masterfrom
tlercher:fix-sha1-aarch64
Closed

sha1: pass block slices to sha1_asm + remove cfg toggle for constants#285
tlercher wants to merge 1 commit into
RustCrypto:masterfrom
tlercher:fix-sha1-aarch64

Conversation

@tlercher
Copy link
Copy Markdown

@tlercher tlercher commented Jul 4, 2021 •
edited
Loading

This doesn't really depend on RustCrypto/asm-hashes#38 but it is required to make it work for me on a M1 Mac.

As the title says i changed the (internal) API so that block slices instead of independent blocks are passes to sha1_asm.

I also removed the cfg toggles for aarch64, because they are required for the software-fallback and asm-aarch64 is marked deprecated anyway.

Benchmarks on my M1 MacBookPro:

Soft

test bench1_10    ... bench:          14 ns/iter (+/- 0) = 714 MB/s
test bench2_100   ... bench:         120 ns/iter (+/- 1) = 833 MB/s
test bench3_1000  ... bench:       1,151 ns/iter (+/- 4) = 868 MB/s
test bench4_10000 ... bench:      11,465 ns/iter (+/- 130) = 872 MB/s

ASM

test bench1_10    ... bench:           7 ns/iter (+/- 0) = 1428 MB/s
test bench2_100   ... bench:          45 ns/iter (+/- 1) = 2222 MB/s
test bench3_1000  ... bench:         459 ns/iter (+/- 9) = 2178 MB/s
test bench4_10000 ... bench:       4,579 ns/iter (+/- 84) = 2183 MB/s

@tarcieri
Copy link
Copy Markdown
Member

tarcieri commented Jul 18, 2021

Oh whoops, didn't see this in time, but the same changes were made in #289. Thanks anyway!

@tarcieri tarcieri closed this Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tlercher @tarcieri