-
Notifications
You must be signed in to change notification settings - Fork 1.3k
added getnewargs() to str.rs #3811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
#3807 was recently merged, which changes how CI runs the test suites. Can you rebase your branch on a fresh copy of
(Of course, everything after the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! you fixed many more than just a single test. Could you please remove expectedFailure
decorators from other successful tests?
@youknowone How can I know which are successful? |
@youknowone Oh, I received message on slack. I'll do that. |
Have you looked at the CI logs? They should give you a clue for where to start looking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor cleanup comments, and I think this should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize if this wasn't clear, but I meant to say the entirety of the lines. Right now these lines are just redundant, and they can go away (along with the extra whitespace).
You mean that delete the test 'functions' which I deleted expectedFailure annotation? |
Any lines that now say def test_function(self):
super().test_function() are just redundant at this point if they're not annotated with a If a test function has something else other than a call to |
Is this right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct. Thank you!
Thank you, too!! |
According to the CI, it seems you may have missed a test in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look good! But maybe you didn't set your git email as your github email.
Do you want to change it before merge?
@zer0who please let me know if you don't care about email address. I don't mind to merge it as it is if you are ok. |
Here is GitHub's documentation to set your commit email address. In order to fix these commits, you can run the following commands:
|
I don't know exatly that email you mentioned, but I did it as I understanded. Is it right? |
Thank you for your help. It was helpful for me. I'm not good at git... so I think it would be hard to explain to me about those things. But I did my best...!!:) Thank you again. |
check |
I forgot to add |
Am I right?? |
@zer0who Yeah It seems good now π |
Here's how you can tell:
|
Thank you so much :) |
Added getnewargs() to str.rs and have tested on test_unicode.py(test_getnewargs())