Update CI toolchain to stable #4051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
hmm, why is this not fixing the error? |
Contributor
Author
Hmm.. I thought it is because the GitHub Actions follows the main branch but it seems not the situtation I thought... |
917924c to
5e9ab13
Compare
youknowone
reviewed
Aug 13, 2022
.github/workflows/ci.yaml
Outdated
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: dtolnay/rust-toolchain@1.62.1 | ||
| - uses: dtolnay/rust-toolchain@1.63.0 |
Member
There was a problem hiding this comment.
Suggested change
| - uses: dtolnay/rust-toolchain@1.63.0 | |
| - uses: dtolnay/rust-toolchain@stable |
using stable is our common way
Contributor
Author
There was a problem hiding this comment.
I applied the suggestion by amending d60baae commit.
Contributor
Author
|
When I saw the debug log, the I'll push with the commit to use |
7c0bdc2 to
5e9ab13
Compare
5e9ab13 to
d60baae
Compare
youknowone
approved these changes
Aug 13, 2022
Member
youknowone
left a comment
There was a problem hiding this comment.
Thank you! the difference between 1.63.0 and stable are confusing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
cargo clippyor the CICheck Rust code with rustfmt and clippyjob failed.It warns
clippy::derive_partial_eq_without_eqas unknown lints but it exists in 1.63.0 release. You can see it through https://rust-lang.github.io/rust-clippy/master/.At the #4046, it updated the toolchain's version to
1.62.1fromstableand thestableversion was1.63.0.But I see the pull request description while writing this pull request's description:
I don't know its context so it may be intended and if then, this pull request should be closed.