-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update zlib from 3.12.6 and _ZlibDecompressor implementation #5476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To fix the failing test, you can run |
I can't seem to see how
can produce a |
Sorry, I just checked CPython code but it doesn't look like that |
…assed to it's __init__
…ates pre-emptively
I resolved a few issues, but currently I'm getting a bunch of |
Additionally |
Also it seems to my knowledge |
Each class need to implement Oh... unlike setstate, getstate doesn't have many implementations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you leave a comment which version of CPython did you brought python source from? (including x in 3.12.x)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
@@ -532,6 +532,10 @@ def requires_legacy_unicode_capi(): | |||
|
|||
has_fork_support = hasattr(os, "fork") and not is_emscripten and not is_wasi | |||
|
|||
# From python 3.12.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry to confuse you. Version was required for commit message, but this is also fine too
After this is merged a few GZip tests are unblocked.