-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update tests for builtin objects to python 3.12.8 #5481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@arihant2math Thank you so much! Are you also interested in 3.13 support? Though it requires a few big tasks, I feel like you fit it by watching zlib and other PRs. I will leave short guide if you are interested in. |
@youknowone thanks for offering, I think I can do it, considering there aren't any language changes or c module updates (from my cursory check). |
@youknowone could this merged for now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, could you rebase it to remove test_int update and revert?
f40677c
to
396df1a
Compare
Fixed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This pr updates the following tests to 3.12.8:
test_int(Fails on wasm, so is not included in this PR)