Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update tests for builtin objects to python 3.12.8 #5481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

arihant2math
Copy link
Collaborator

@arihant2math arihant2math commented Jan 18, 2025

This pr updates the following tests to 3.12.8:

  • test_int (Fails on wasm, so is not included in this PR)
  • test_float
  • test_unary
  • test_numbers
  • test_list
  • test_listcomps

@arihant2math arihant2math marked this pull request as ready for review January 18, 2025 02:25
@youknowone
Copy link
Member

@arihant2math Thank you so much! Are you also interested in 3.13 support? Though it requires a few big tasks, I feel like you fit it by watching zlib and other PRs. I will leave short guide if you are interested in.

@arihant2math
Copy link
Collaborator Author

@youknowone thanks for offering, I think I can do it, considering there aren't any language changes or c module updates (from my cursory check).

@arihant2math
Copy link
Collaborator Author

@youknowone could this merged for now?

Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, could you rebase it to remove test_int update and revert?

@arihant2math
Copy link
Collaborator Author

Fixed it

Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowone youknowone merged commit c642aef into RustPython:main Jan 20, 2025
11 checks passed
@arihant2math arihant2math deleted the builtins-312 branch January 20, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants