Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump libffi #5779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

Bump libffi #5779

merged 1 commit into from
Jun 23, 2025

Conversation

arihant2math
Copy link
Collaborator

@arihant2math arihant2math commented May 10, 2025 •
edited by coderabbitai bot
Loading

Also remove system feature from JIT, as that forces libffi to be installed on the system and doesn't have a real benefit.

Summary by CodeRabbit

  • Chores
    • Updated the version of the libffi dependency to 4.1.
    • Removed the "system" feature flag from the libffi dependency.

youknowone
youknowone approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase it

@arihant2math
Copy link
Collaborator Author

@youknowone fixed.

@arihant2math arihant2math force-pushed the libffi-upgrade branch 2 times, most recently from f442e67 to 3480f36 Compare May 17, 2025 06:09
@youknowone
Copy link
Member

Cargo.lock is removed

@arihant2math
Copy link
Collaborator Author

Closed by mistake.

@arihant2math arihant2math reopened this May 18, 2025
@youknowone
Copy link
Member

Cargo.lock must not be removed

@arihant2math
Copy link
Collaborator Author

@youknowone fixed

@arihant2math @youknowone
Bump libffi
cf37fba 
Also remove system feature from jit libffi, as that forces libffi to be installed on the system
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 23, 2025 •
edited
Loading

Walkthrough

The updates involve modifying the libffi dependency in two Cargo.toml files. The root Cargo.toml increases the libffi version from 4.0 to 4.1, while the jit/Cargo.toml removes the "system" feature flag from the libffi dependency, now including it without any feature flags.

Changes

File(s) Change Summary
Cargo.toml Updated libffi dependency version from 4.0 to 4.1.
jit/Cargo.toml Removed "system" feature flag from libffi dependency.

Poem

In the garden of code we hop along,
Updating crates to keep them strong.
A version hops, a flag takes flight,
Dependencies trimmed just right.
With every change, the project grows—
A rabbit’s touch, and onward it goes! 🐇

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jun 23, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
Cargo.toml (1)

172-172: Bump libffi to 4.1 — verify and unify
Ensure the new 4.1 release exists on crates.io, update and commit your Cargo.lock (cargo update -p libffi --precise 4.1), and confirm all CI pipelines pass. For consistency across workspace crates, consider adding a [patch.crates-io] override at the workspace root to enforce libffi v4.1.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9952c97 and cf37fba.

📒 Files selected for processing (2)
  • Cargo.toml (1 hunks)
  • jit/Cargo.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Run snippets and cpython tests (windows-latest)
  • GitHub Check: Run tests under miri
  • GitHub Check: Check Rust code with rustfmt and clippy
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Run rust tests (windows-latest)
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Ensure compilation on various targets
🔇 Additional comments (1)
jit/Cargo.toml (1)

18-18: Remove system feature from libffi — confirm default linking
Dropping the system feature simplifies the JIT build, but verify that the default feature set of the libffi crate still compiles and links correctly on Linux, macOS, and Windows.

@youknowone youknowone merged commit 70bcd78 into RustPython:main Jun 23, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arihant2math @youknowone