More tkinter #5784
Open
More tkinter #5784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
Signed-off-by: Ashwin Naren <[email protected]>
youknowone
requested changes
May 13, 2025
youknowone
requested changes
May 19, 2025
| @@ -272,8 +272,8 @@ mod _tkinter { | |||
| // TODO: technically not thread safe | |||
| let name = varname_converter(name, vm)?; | |||
|
|
|||
| let name = ffi::CString::new(name).unwrap(); | |||
| let name2 = ffi::CString::new(name2.unwrap_or_default()).unwrap(); | |||
| let name = ffi::CString::new(name)?; | |||
There was a problem hiding this comment.
I doubt this is buildable.
ToPyException requires vm
There was a problem hiding this comment.
@arihant2math could you check this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still have no idea why getvar can't find tk_version and tcl_version, but that's an issue for another time.