Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Unmark fixed tests #5818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2025
Merged

Unmark fixed tests #5818

merged 1 commit into from
Jun 22, 2025

Conversation

moreal
Copy link
Contributor

@moreal moreal commented Jun 22, 2025 •
edited by coderabbitai bot
Loading

This pull request just unmark fixed test.

Summary by CodeRabbit

  • Tests
    • Enabled the test for restored object creation in class properties and methods, allowing it to run during test execution.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 22, 2025 •
edited
Loading

Walkthrough

The update removes the @unittest.expectedFailure and @unittest.skip decorators from the test_restored_object_new method within the ClassPropertiesAndMethods test class in Lib/test/test_descr.py. As a result, this test will now execute as a standard test case during test runs.

Changes

File(s) Change Summary
Lib/test/test_descr.py Removed @unittest.expectedFailure and @unittest.skip decorators from one test method.

Poem

The rabbit hops, the tests now run,
No skips or failures—just pure fun!
With old marks gone, the code is spry,
Each test will give a truthful try.
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d68313 and 6673be5.

📒 Files selected for processing (1)
  • Lib/test/test_descr.py (0 hunks)
💤 Files with no reviewable changes (1)
  • Lib/test/test_descr.py
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@moreal moreal force-pushed the unmark-decorators branch from 04fded5 to 26536a6 Compare June 22, 2025 13:32
@moreal moreal changed the title Unmark skip-like decorators for resolved ones Unmark fixed tests Jun 22, 2025
@moreal moreal force-pushed the unmark-decorators branch from 26536a6 to 6673be5 Compare June 22, 2025 14:18
@moreal moreal marked this pull request as ready for review June 22, 2025 22:59
@youknowone youknowone merged commit dfc8fe0 into RustPython:main Jun 22, 2025
12 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jun 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moreal @youknowone