Thanks to visit codestin.com
Credit goes to github.com

Skip to content

implement more property features #5828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 24, 2025
Merged

implement more property features #5828

merged 5 commits into from
Jun 24, 2025

Conversation

youknowone
Copy link
Member

@youknowone youknowone commented Jun 24, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes

    • Improved error messages when accessing properties without a getter, setter, or deleter, providing clearer details about the property and object involved.

  • Refactor

    • Enhanced handling of property docstrings, especially for subclasses and when the docstring is derived from the getter method.
    • Unified and streamlined the logic for cloning and updating property accessors (getter, setter, deleter).
    • Refined detection of abstract methods on properties.

  • Tests

    • Updated tests to remove expected failure markers from cases related to property behavior.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 24, 2025 •
edited
Loading

Warning

Rate limit exceeded

@youknowone has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 23 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between db7dd4f and 8e12d9e.

📒 Files selected for processing (1)
  • Lib/test/test_descr.py (0 hunks)

Walkthrough

The changes update the Rust implementation of Python's property type by adding a flag to track if documentation is derived from the getter, refining error messages, and unifying logic for cloning properties with updated accessors. Corresponding Python tests remove the @unittest.expectedFailure decorator from several methods, maintaining only conditional skips.

Changes

File(s) Change Summary
Lib/test/test_property.py Removed @unittest.expectedFailure decorators from multiple tests, retaining only @unittest.skipIf as needed. No test logic altered.
vm/src/builtins/property.rs Added getter_doc flag, improved error messages, unified property cloning logic, refined docstring handling, and updated isabstractmethod logic. Modified public and private methods accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PythonVM
    participant PyProperty

    User->>PythonVM: Access property (get/set/delete)
    PythonVM->>PyProperty: Call appropriate method (getter/setter/deleter)
    PyProperty-->>PythonVM: If accessor missing, format error with property name/type
    PythonVM-->>User: Return result or error message
Loading 
sequenceDiagram
    participant User
    participant PythonVM
    participant PyProperty

    User->>PythonVM: Create or modify property (getter/setter/deleter)
    PythonVM->>PyProperty: clone_property_with(new accessor)
    PyProperty->>PyProperty: Copy fields, update docstring if getter changed
    PyProperty-->>PythonVM: Return new property instance
Loading

Poem

In the warren, code grows neat and spry,
Properties now tell you "why!"
With docs from getters, errors made clear,
No more expected failures here.
A hop, a skip, the tests all run—
This rabbit’s work is never done!
🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@youknowone youknowone merged commit 86d8d23 into RustPython:main Jun 24, 2025
12 checks passed
@youknowone youknowone deleted the property branch June 24, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@youknowone