This repository was archived by the owner on Mar 22, 2024. It is now read-only.
Improve use StringCursor instead index based char fetch #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowone
approved these changes
Jan 17, 2024
Comment on lines
+2
to
+5
| pub struct StringCursor { | ||
| pub(crate) ptr: *const u8, | ||
| pub position: usize, | ||
| } |
There was a problem hiding this comment.
Is this &[u8] or different to it?
e.g. will this version work?
pub struct StringCursor {
bytes: &[u8],
}
cursor.bytes = ...
There was a problem hiding this comment.
Nop, position is character position, ptr is bytes cursor.
933b484 to
9725808
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17