Ensure all the session delegate completionHandler called #2197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e59d0b to
ead067f
Compare
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #2197 +/- ##
==========================================
- Coverage 78.59% 78.38% -0.22%
==========================================
Files 36 36
Lines 3635 3641 +6
Branches 322 335 +13
==========================================
- Hits 2857 2854 -3
- Misses 756 765 +9
Partials 22 22
Continue to review full report at Codecov.
|
08ac888 to
7f91504
Compare
…k when response error code below iOS 10
7f91504 to
9080afd
Compare
dreampiggy
commented
Jan 29, 2018
| } else { | ||
| NSUInteger code = ((NSHTTPURLResponse *)response).statusCode; |
There was a problem hiding this comment.
Even through the status code in invalid. We should also store the actual response and post the notification to let user decide the action. Current implementation contains bug.
And also, for 304, it should not directly call cancelInternal, which will cause the completion block not been called at all. Because cancelInternal remove all the callback blocks.
mythodeia
approved these changes
Jan 29, 2018
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fix the leak when response error code below iOS 10
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / reffers to the following issues: #1953 #1305 #1597
Pull Request Description
Our usage to let
SDWebImageDownloaderto passURLSessionDelegateto the operation seems a wrong design. It's because that sometimes, theSDWebImageDownloaderOperationwill be a nil. Because in Apple's doc about URLSession life cycle. It does not means thatdidCompleteWithError:is the final call. But at that time we already removed theSDWebImageDownloaderOperationfrom the operation queue. So some of delegate methods will not do the correct way like the URLSession behavior, especially some delegate which contains acompletionBlock. If you not call that, the URLSession will mass up.Currently we do not totally change something, but we should add a protect. If the
SDWebImageDownloaderOperationis nil, we just use the default behavior in the documentation from Apple.So for #1953, I found the reason. By the time
URLSession:dataTask:willCacheResponse:completionHandler:is called when the server response a 404 error, theSDWebImageDownloaderOperationis already become nil, so this will cause memory leak below iOS 10. Actually Apple already warn you in the doc