feat(google-cast-sender): add the ability to replay media #104
+43
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #94 by adding the ability to replay the media when it reaches the end. This feature relies on the media that was previously loaded locally. The reason is that when the receiver reaches the end of playback, the media session is removed. - update the `play` function to allow reloading the media when it reaches the end of playback and the `replay` button is shown - update the `ended` function to return `undefined` if no source is loaded - update unit tests
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #94 by adding the ability to replay the media when it reaches the end. This feature relies on the media that was previously loaded locally. The reason is that when the receiver reaches the end of playback, the media session is removed.
Changes Made
playfunction to allow reloading the media when it reaches the end of playback and thereplaybutton is shownendedfunction to returnundefinedif no source is loadedChecklist