Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(svg-button): allow icon update throw the appendIcon function #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

feat(svg-button): allow icon update throw the appendIcon function #97

merged 1 commit into from
Sep 17, 2025

Conversation

jboix
Copy link
Member

@jboix jboix commented Sep 16, 2025

Description

Allows the current icon to be updated so that extending components can reflect dynamic state changes.

Changes Made

  • Extended the SvgButton and SvgComponent API to allow the displayed icon to be updated so that components can reflect dynamic state changes.

Checklist

  • I have followed the project's style and contribution guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.

@jboix
feat(svg-button): allow icon update throw the appendIcon function
de34a5f 
Allows the current icon to be updated so that extending components can
reflect dynamic state changes.
@jboix jboix self-assigned this Sep 16, 2025
@jboix jboix added this to Pillarbox Sep 16, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Sep 16, 2025
@jboix jboix moved this from 📋 Backlog to 🍿 Code Review in Pillarbox Sep 16, 2025
@jboix jboix requested a review from amtins September 16, 2025 06:50
@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 96.78% 4402 / 4548
🔵 Statements 96.78% 4402 / 4548
🔵 Functions 93.8% 318 / 339
🔵 Branches 88.81% 524 / 590
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/svg-button/src/svg-button.js 100% 100% 100% 100%
packages/svg-button/src/svg-component.js 97.27% 88.88% 100% 97.27% 67-70
packages/svg-button/src/svg-icon-loader.js 100% 85.71% 100% 100%
Generated in workflow #209 for commit de34a5f by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2025 •
edited
Loading

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-09-17 07:45 UTC

@jboix jboix mentioned this pull request Sep 16, 2025
Open
4 tasks
amtins
amtins approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work thank you!

@jboix jboix merged commit aff8a6f into main Sep 17, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Sep 17, 2025
@jboix jboix deleted the feat/allow-icon-change branch September 17, 2025 07:45
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version @srgssr/svg-button-v1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amtins amtins amtins approved these changes

Assignees

@jboix jboix

Labels
released
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jboix @amtins