Fix "does not include header 'SVProgressHUD-Framework.h'" warning when installed via Carthage#521
Fix "does not include header 'SVProgressHUD-Framework.h'" warning when installed via Carthage#521manlycode wants to merge 2 commits into
Conversation
When installing SVProgressHUD with Carthage, I received the following warning: ``` <module-includes>:1:1: Umbrella header for module 'SVProgressHUD' does not include header 'SVProgressHUD-Framework.h' ```
Fix warning when including SVProgressHUD as an embedded Framework:
|
Please look at #509. |
|
@honkmaster These are different issues. The information in #509 isn't helpful for the issue I'm attempting to fix. |
|
I understand this. However, why was the header removed with #500 by @flovilmart and now it should be added back?! I am not using Carthage and am now a little bit confused. Maybe you should talk to @flovilmart. |
|
@honkmaster I see what you mean now. I can't tell from the PR context of #500 as to what conditions this warning was showing. It seems like @flovilmart fixed the same thing by doing the opposite of what I did in this PR (#521). @flovilmart Could you elaborate on what conditions you were getting the warning that #500 fixed. I was seeing the following error:
|
|
Any feedback? |
|
I received same warning under same conditions. |
|
The SVProgressHUD-framework.h header was removed because it was useless and actually breaking with swift import directive Without the modulemap.map. Now that you added it back, that should work too. That's still odd that you have that warning as with the PR #500 it should have disappear |
|
I was using 1.1.3. After switching to 2.0-beta8, warning disappeared. Thanks! |
|
What is the conclusion? I understand @flovilmart reasons against the header. In Addition @akio0911`s answers sounds like the issue is fixed. |
|
Looks like @akio0911 was using an old version. I believe we can close. |
|
Then let`s do this. |
When installing SVProgressHUD via Carthage, I received the following warning:
This fixes that warning.