Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix "does not include header 'SVProgressHUD-Framework.h'" warning when installed via Carthage#521

Closed
manlycode wants to merge 2 commits into
SVProgressHUD:masterfrom
collectiveidea:master
Closed

Fix "does not include header 'SVProgressHUD-Framework.h'" warning when installed via Carthage#521
manlycode wants to merge 2 commits into
SVProgressHUD:masterfrom
collectiveidea:master

Conversation

@manlycode

Copy link
Copy Markdown

When installing SVProgressHUD via Carthage, I received the following warning:

<module-includes>:1:1: Umbrella header for module 'SVProgressHUD' does not include header 'SVProgressHUD-Framework.h'

This fixes that warning.

When installing SVProgressHUD with Carthage, I received the following warning:
```
<module-includes>:1:1: Umbrella header for module 'SVProgressHUD' does not include header 'SVProgressHUD-Framework.h'
```
Fix warning when including SVProgressHUD as an embedded Framework:
@honkmaster

Copy link
Copy Markdown
Member

Please look at #509.

@manlycode

Copy link
Copy Markdown
Author

@honkmaster These are different issues. The information in #509 isn't helpful for the issue I'm attempting to fix.

@honkmaster

Copy link
Copy Markdown
Member

I understand this. However, why was the header removed with #500 by @flovilmart and now it should be added back?! I am not using Carthage and am now a little bit confused. Maybe you should talk to @flovilmart.

@manlycode

Copy link
Copy Markdown
Author

@honkmaster I see what you mean now. I can't tell from the PR context of #500 as to what conditions this warning was showing. It seems like @flovilmart fixed the same thing by doing the opposite of what I did in this PR (#521).

@flovilmart Could you elaborate on what conditions you were getting the warning that #500 fixed.

I was seeing the following error: <module-includes>:1:1: Umbrella header for module 'SVProgressHUD' does not include header 'SVProgressHUD-Framework.h' under the following conditions:

  • Pure Swift project (no bridging header)
  • Installed with Carthage

@honkmaster

Copy link
Copy Markdown
Member

Any feedback?

@akio0911

Copy link
Copy Markdown

I received same warning under same conditions.

@flovilmart

Copy link
Copy Markdown
Contributor

The SVProgressHUD-framework.h header was removed because it was useless and actually breaking with swift import directive Without the modulemap.map. Now that you added it back, that should work too. That's still odd that you have that warning as with the PR #500 it should have disappear

@akio0911

akio0911 commented Feb 1, 2016

Copy link
Copy Markdown

I was using 1.1.3. After switching to 2.0-beta8, warning disappeared. Thanks!

@honkmaster

Copy link
Copy Markdown
Member

What is the conclusion? I understand @flovilmart reasons against the header. In Addition @akio0911`s answers sounds like the issue is fixed.

@flovilmart

Copy link
Copy Markdown
Contributor

Looks like @akio0911 was using an old version. I believe we can close.

@honkmaster

Copy link
Copy Markdown
Member

Then let`s do this.

@honkmaster honkmaster closed this Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants