Open
Conversation
Collaborator
|
review later after my group meeting |
kurikomoe
requested changes
Jun 16, 2024
| else: | ||
| handle(args.output_path, args.data_path, args.text_length, args.compare_text) | ||
| if args.shutdown == 1: | ||
| os.system("/usr/bin/shutdown") |
Collaborator
There was a problem hiding this comment.
First, you cannot assume that the user is using Linux. Also, if the user is on Linux, using python xxx.py && shutdown should be a better approach. I think that shutdown would be more useful for Windows users.
Second, shutdown is a command requiring elevated privileges in most Linux distributions. I don't think this can work without sudo or root, so some checks should be added before the time-consuming translation task to ensure the args.shutdown branch won't fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.新增批量翻译目录下的txt与srt文件
2.文本翻译新增关机可选项,翻译任务完成即可关机,节省gpu资源成本