Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use private GitHub Actions runners #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 18, 2024
Merged

Use private GitHub Actions runners #108

merged 3 commits into from
Jan 18, 2024

Conversation

sella_sfemu
Copy link
Mannequin

@sella_sfemu sella_sfemu mannequin commented Jan 17, 2024

Due to IP restriction, only jobs running in Enterprise runners can
access Salesforce repositories.

Critical Changes

Changes

Issues Closed

New Metadata

Deleted Metadata

Definition of Done

Refer to Definition of Done to see any additional details for the items below:

  • Any net new LWC work has JEST test coverage 50% or above
  • Default Sa11y tests pass for all LWC components
  • 🔒 Secure both Front-end (LWC) & back-end (Apex) as necessary
  • 🔑 Grant users access in Permission Sets (Object, Field, Apex Class) as necessary
  • Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name
  • Make sure that ACs are updated (if any gaps)
  • Add Open Source short version license if new files suppport inline comments. For more information check SHORT_VERSION_LICENSE_GUIDELINES readme.
  • All acceptance criteria have been met
    • Developer
    • Code Reviewer
  • Pull Request contains draft release notes
  • Labels, help text, and customer facing messages are reviewed by Docs
  • QE story level testing completed

@sella_sfemu sella_sfemu mannequin requested a review from jestevez_sfemu January 17, 2024 18:35
jestevez_sfemu
jestevez_sfemu mannequin reviewed Jan 17, 2024
View reviewed changes
Copy link
Mannequin

@jestevez_sfemu jestevez_sfemu mannequin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODEOWNERS 🆗

@sella_sfemu sella_sfemu mannequin dismissed stale reviews from ghost via c5ae283 January 18, 2024 16:07
@sella_sfemu sella_sfemu mannequin dismissed a stale review via 4494b06 January 18, 2024 21:05
spelak_sfemu
spelak_sfemu mannequin approved these changes Jan 18, 2024
View reviewed changes
@sella_sfemu sella_sfemu mannequin merged commit 758718e into main Jan 18, 2024
@sella_sfemu sella_sfemu mannequin deleted the feature/github-actions-private-runners branch January 18, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spelak_sfemu spelak_sfemu spelak_sfemu approved these changes

@jestevez_sfemu jestevez_sfemu jestevez_sfemu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sella_sfemu @jestevez_sfemu @spelak_sfemu @sella24