Adding DatabaseService class #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updating reference on FileController, FileService, and FileSelector to
work with the new version of DataBaseService implemented on OFM repo.
Also, the test classes are being updated to work with the new version
of the UnitTest and TestUser framework.
- Updated classes:
- FileController
- FileController_TEST
- FileService
- FileService_TEST
- FileSelector
- FileSelector_TEST
- DatabaseService
- DatabaseService_TEST
- UnitTest
- TestUser
- Removed classes:
- SecurityService
- SecurityService_TEST
- BasicStub
- TestUtils
…to feature/231__view-requirement__complete-requirement__classes-update
Repository owner
requested a review
from spelak_sfemu
March 12, 2021 19:38
| @@ -71,6 +71,7 @@ public with sharing class FileService { | |||
| ) { | |||
| List<Database.DeleteResult> results = new List<Database.DeleteResult>(); | |||
| List<Id> contentDocumentLinkIdsToDelete = new List<Id>(); | |||
| List<ContentDocumentLink> contentDocumentLinkToDelete = new List<ContentDocumentLink>(); | |||
There was a problem hiding this comment.
Tweak to variable name to indicate it's a collection: contentDocumentLinksToDelete instead of contentDocumentLinkToDelete.
| 'System Administrator', | ||
| ADMIN_USER_EMAIL | ||
| ); | ||
| User adminWithRole = createUser('System Administrator', ADMIN_USER_EMAIL); |
There was a problem hiding this comment.
Can we TestUser instead to create test users?
Copy over these methods and classes from the TestUser in GMS and make sure to convert "Grantseeker" to "Fundseeker" and use the profile this repo ships.
public static final Boolean IS_PERSON_ACCOUNTS_ENABLED = Schema.SObjectType.Account.fields.getMap().get('IsPersonAccount') != null;static Id getFirstBusinessAccountRecordTypeId()static Id getFirstPersonAccountRecordTypeId()with sharing virtual class BusinessGrantseekerPersona extends TestUser.Personawith sharing virtual class PersonGrantseekerPersona extends BusinessGrantseekerPersona
- In this commit we are removing the reference made on the createUser method in FileSelector_TEST class. Now we are using the TestUser framework to create personas based on the test scenario. - FileController_TEST - FileSelector_TEST - FileService_TEST - TestUser
…asses-update' of github.com:SalesforceFoundation/OutboundFundsCommunity into feature/231__view-requirement__complete-requirement__classes-update
Repository owner
requested a review
from spelak_sfemu
March 16, 2021 04:14
There was a problem hiding this comment.
@jdavilasf , changes look good at a high level. Feel free to merge this in the parent branch so we can see the final result in the parent branch.
Repository owner
merged commit Mar 16, 2021
d08f35a
into
feature/231__view-requirement__complete-requirement
Repository owner
deleted the
feature/231__view-requirement__complete-requirement__classes-update
branch
March 16, 2021 15:26
spelak_sfemu mannequin
pushed a commit
that referenced
this pull request
May 11, 2022
Fixes dependendabot issues: - [Prototype Pollution in yargs-parser #9](https://github.com/SalesforceFoundation/OutboundFundsModuleSite/security/dependabot/9) - [Exposure of sensitive information in follow-redirects #19](https://github.com/SalesforceFoundation/OutboundFundsModuleSite/security/dependabot/19) - [Exposure of Sensitive Information to an Unauthorized Actor in follow-redirects #21](https://github.com/SalesforceFoundation/OutboundFundsModuleSite/security/dependabot/21) - [Prototype Pollution in minimist #23](https://github.com/SalesforceFoundation/OutboundFundsModuleSite/security/dependabot/23)
spelak_sfemu mannequin
pushed a commit
that referenced
this pull request
May 12, 2022
Fixes dependendabot issues: - [Prototype Pollution in yargs-parser #9](https://github.com/SalesforceFoundation/OutboundFundsModuleSite/security/dependabot/9) - [Exposure of sensitive information in follow-redirects #19](https://github.com/SalesforceFoundation/OutboundFundsModuleSite/security/dependabot/19) - [Exposure of Sensitive Information to an Unauthorized Actor in follow-redirects #21](https://github.com/SalesforceFoundation/OutboundFundsModuleSite/security/dependabot/21) - [Prototype Pollution in minimist #23](https://github.com/SalesforceFoundation/OutboundFundsModuleSite/security/dependabot/23)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata
Definition of Done
Refer to Definition of Done to see any additional details for the items below: