Thanks to visit codestin.com
Credit goes to github.com

Skip to content

W-10048303: [OFM-Site] Resolve all known dependabot alerts #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Dec 17, 2021
Merged

W-10048303: [OFM-Site] Resolve all known dependabot alerts #80

merged 21 commits into from
Dec 17, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 29, 2021

W-10048303 [OFM-Site] Resolve all known dependabot alerts
Resolve all known dependabot alerts

Critical Changes

Changes

Issues Closed

New Metadata

Deleted Metadata

Definition of Done

Refer to Definition of Done to see any additional details for the items below:

  • Any net new LWC work has JEST test coverage 50% or above
  • Default Sa11y tests pass for all LWC components
  • 🔒 Secure both Front-end (LWC) & back-end (Apex) as necessary
  • 🔑 Grant users access in Permission Sets (Object, Field, Apex Class) as necessary
  • Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name
  • Make sure that ACs are updated (if any gaps)
  • Add Open Source short version license if new files suppport inline comments. For more information check SHORT_VERSION_LICENSE_GUIDELINES readme.
  • All acceptance criteria have been met
    • Developer
    • Code Reviewer
  • Pull Request contains draft release notes
  • Labels, help text, and customer facing messages are reviewed by Docs
  • QE story level testing completed

Repository owner requested a review from jestevez_sfemu November 30, 2021 14:59
Repository owner added ready for RE review This Pull Request still needs a RE review. 🎯 this sprint This Pull Request is related to a Work Item committed in this sprint labels Nov 30, 2021
jestevez_sfemu
jestevez_sfemu mannequin reviewed Dec 1, 2021
View reviewed changes
Copy link
Mannequin

@jestevez_sfemu jestevez_sfemu mannequin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODEOWNERS 🆗

@jestevez_sfemu jestevez_sfemu mannequin removed the ready for RE review This Pull Request still needs a RE review. label Dec 1, 2021
Repository owner dismissed a stale review via 8603e8a December 6, 2021 22:10
Repository owner added the in dev review Developer is actively reviewing label Dec 14, 2021
ghost
ghost reviewed Dec 16, 2021
View reviewed changes
Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

Repository owner dismissed a stale review December 16, 2021 16:38
ghost
ghost approved these changes Dec 16, 2021
View reviewed changes
Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks great. Thanks!

@ghost
Copy link
Author

ghost commented Dec 16, 2021

@jstvz - This PR has changed since the initial review. Can you please take another look? Thanks!

Repository owner added the ready for RE review This Pull Request still needs a RE review. label Dec 16, 2021
Repository owner merged commit e2005ac into main Dec 17, 2021
Repository owner deleted the feature/dependabot-alerts-site branch December 17, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jestevez_sfemu jestevez_sfemu jestevez_sfemu approved these changes

Assignees
No one assigned
Labels
in dev review Developer is actively reviewing ready for RE review This Pull Request still needs a RE review. 🎯 this sprint This Pull Request is related to a Work Item committed in this sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ghost @jestevez_sfemu @a-contreras @jstvz