Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Shared CODEOWNERS workflow #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2021
Merged

Shared CODEOWNERS workflow #82

merged 1 commit into from
Dec 16, 2021

Conversation

marcel-pufal_sfemu
Copy link
Mannequin

@marcel-pufal_sfemu marcel-pufal_sfemu mannequin commented Dec 16, 2021

This commit uses the new GitHub Actions feature to reuse a workflow stored in another repository (see also: workflow documentation).

Critical Changes

Changes

Issues Closed

New Metadata

Deleted Metadata

Definition of Done

Refer to Definition of Done to see any additional details for the items below:

  • Any net new LWC work has JEST test coverage 50% or above
  • Default Sa11y tests pass for all LWC components
  • 🔒 Secure both Front-end (LWC) & back-end (Apex) as necessary
  • 🔑 Grant users access in Permission Sets (Object, Field, Apex Class) as necessary
  • Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name
  • Make sure that ACs are updated (if any gaps)
  • Add Open Source short version license if new files suppport inline comments. For more information check SHORT_VERSION_LICENSE_GUIDELINES readme.
  • All acceptance criteria have been met
    • Developer
    • Code Reviewer
  • Pull Request contains draft release notes
  • Labels, help text, and customer facing messages are reviewed by Docs
  • QE story level testing completed

@marcel-pufal_sfemu marcel-pufal_sfemu mannequin requested a review from jkofsky_sfemu December 16, 2021 22:22
@ghost
Copy link

ghost commented Dec 16, 2021

Hi 👋 @codexmarcel! Release Engineering asks that teams use the following process for routine reviews:

  1. After creating a non-draft pull request that includes automation updates, a release engineer will be auto-assigned to the PR.
  2. When dev review is complete and the PR is ready for the release engineer to review, add a "ready for RE review" label to the PR to let us know when the PR is ready for us to review.
  3. If you've added the "ready for RE review" label but haven't received a review within a 36 hours, @-mention the assigned RE in a comment on the PR.
  4. If you don't receive a response from the assigned RE by the end of the next business day (or your request is urgent), post a message to #sfdo-releng-support that includes a link to this PR and one of us will review as soon as we're able.

@marcel-pufal_sfemu marcel-pufal_sfemu mannequin added the ready for RE review This Pull Request still needs a RE review. label Dec 16, 2021
@ghost
Copy link

ghost commented Dec 16, 2021

This PR has been labeled as ready for Release Engineering review by
@codexmarcel. Reviews have been requested from: @jofsky.

@jestevez_sfemu jestevez_sfemu mannequin removed the ready for RE review This Pull Request still needs a RE review. label Dec 16, 2021
@jestevez_sfemu jestevez_sfemu mannequin merged commit 62ed292 into main Dec 16, 2021
@jestevez_sfemu jestevez_sfemu mannequin deleted the feature/actions-shared-codeowners branch December 16, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jestevez_sfemu jestevez_sfemu jestevez_sfemu approved these changes

@jkofsky_sfemu jkofsky_sfemu Awaiting requested review from jkofsky_sfemu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcel-pufal_sfemu @ghost @jestevez_sfemu @codexmarcel