Thanks to visit codestin.com
Credit goes to github.com

Skip to content

W-10330211 Removing isotope dependency #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2022
Merged

W-10330211 Removing isotope dependency #86

merged 2 commits into from
Jan 4, 2022

Conversation

spelak_sfemu
Copy link
Mannequin

@spelak_sfemu spelak_sfemu mannequin commented Dec 20, 2021

W-10330211

The following layouts no longer exclude the IsotopeSubscription button
to remove the dependency on Isotope being enabled for the org:

  • outfunds__Disbursement__c-OFM Disbursement Site Layout.layout-meta.xml
  • outfunds__Funding_Program__c-OFM Funding Program Site Layout.layout-meta.xml
  • outfunds__Funding_Request__c-OFM Funding Request Site Layout.layout-meta.xml
  • outfunds__Requirement__c-OFM Requirement Site Layout.layout-meta.xml

Critical Changes

Changes

  • We fixed an issue that only affects customers who tried to install Outbound Funds Module for Experience Cloud after the 236 release. We removed aspects of page layouts that caused the installer to error out. These layouts no longer exclude the IsotopeSubscription button:
    • OFM Disbursement Site Layout
    • OFM Funding Program Site Layout
    • OFM Funding Request Site Layout
    • OFM Requirement Site Layout

Issues Closed

New Metadata

Deleted Metadata

Definition of Done

Refer to Definition of Done to see any additional details for the items below:

  • Any net new LWC work has JEST test coverage 50% or above
  • Default Sa11y tests pass for all LWC components
  • 🔒 Secure both Front-end (LWC) & back-end (Apex) as necessary
  • 🔑 Grant users access in Permission Sets (Object, Field, Apex Class) as necessary
  • Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name
  • Make sure that ACs are updated (if any gaps)
  • Add Open Source short version license if new files suppport inline comments. For more information check SHORT_VERSION_LICENSE_GUIDELINES readme.
  • All acceptance criteria have been met
    • Developer
    • Code Reviewer
  • Pull Request contains draft release notes
  • Labels, help text, and customer facing messages are reviewed by Docs
  • QE story level testing completed

@spelak-salesforce
Removing isotope dependency
fe1bf73 
The following layouts no longer exclude the `IsotopeSubscription` button
to remove the dependency on Isotope being enabled for the org:
- `outfunds__Disbursement__c-OFM Disbursement Site Layout.layout-meta.xml`
- `outfunds__Funding_Program__c-OFM Funding Program Site Layout.layout-meta.xml`
- `outfunds__Funding_Request__c-OFM Funding Request Site Layout.layout-meta.xml`
- `outfunds__Requirement__c-OFM Requirement Site Layout.layout-meta.xml`
@spelak_sfemu spelak_sfemu mannequin added 🎯 this sprint This Pull Request is related to a Work Item committed in this sprint 🚧 wip 🧯💨 Work in progress labels Dec 20, 2021
@spelak_sfemu spelak_sfemu mannequin self-assigned this Dec 20, 2021
@spelak_sfemu spelak_sfemu mannequin changed the title Removing isotope dependency W-10330211 Removing isotope dependency Dec 20, 2021
@spelak_sfemu spelak_sfemu mannequin changed the base branch from main to feature/234 December 20, 2021 15:47
@spelak_sfemu spelak_sfemu mannequin added ready for QE Ready for QE review DO NOT MERGE and removed 🚧 wip 🧯💨 Work in progress labels Dec 20, 2021
sella_sfemu
sella_sfemu mannequin suggested changes Dec 20, 2021
View reviewed changes
Copy link
Mannequin

@sella_sfemu sella_sfemu mannequin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job.
Can you also remove the exclude changeRecordType from the page layouts, for consistency ?

@sella_sfemu sella_sfemu mannequin added Changes requested QE in Progress QE is actively reviewing this Pull Request and removed ready for QE Ready for QE review labels Dec 20, 2021
@spelak_sfemu
Copy link
Mannequin Author

spelak_sfemu mannequin commented Dec 20, 2021

  • outfunds__Requirement__c-OFM Requirement Site Layout.layout-meta.xml

@sella24 , I don't think we should un-exclude ChangeRecordType for the following layouts since the Edit button is excluded implying the object records should not be modifiable in the Community UI even if the user has API access to do so:

  • OFM Disbursement Site Layout
  • OFM Funding Program Site Layout
  • OFM Requirement Site Layout

For the OFM Funding Request Site Layout, modification of the Funding Request in the Community UI is allowed, so I un-excluded the ChangeRecordType button.

@spelak-salesforce
un-excluding Funding Request ChangeRecordType
9f05280 
For the OFM Funding Request Site Layout, modification of the Funding Request in the Community UI is allowed, so I un-excluded the `ChangeRecordType` button.

However, I don't think we should un-exclude `ChangeRecordType` for the following layouts since the `Edit` button is excluded implying the object records should not be modifiable in the Community UI:
- OFM Disbursement Site Layout
- OFM Funding Program Site Layout
- OFM Requirement Site Layout
@spelak_sfemu spelak_sfemu mannequin changed the base branch from feature/234 to main December 20, 2021 19:21
@sella_sfemu sella_sfemu mannequin self-requested a review December 20, 2021 20:50
sella_sfemu
sella_sfemu mannequin approved these changes Dec 20, 2021
View reviewed changes
@sella_sfemu sella_sfemu mannequin added Integrate All reviews are complete and removed QE in Progress QE is actively reviewing this Pull Request Changes requested labels Dec 20, 2021
@spelak_sfemu spelak_sfemu mannequin marked this pull request as ready for review January 3, 2022 15:58
@spelak_sfemu spelak_sfemu mannequin requested a review from fwashington_sfemu January 3, 2022 15:58
fwashington_sfemu
fwashington_sfemu mannequin approved these changes Jan 4, 2022
View reviewed changes
Copy link
Mannequin

@fwashington_sfemu fwashington_sfemu mannequin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@spelak_sfemu spelak_sfemu mannequin merged commit 922176b into main Jan 4, 2022
@spelak_sfemu spelak_sfemu mannequin deleted the feature/234__remove-isotope-dependency branch January 4, 2022 22:16
Repository owner unassigned spelak_sfemu Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwashington_sfemu fwashington_sfemu fwashington_sfemu approved these changes

@sella_sfemu sella_sfemu sella_sfemu approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE Integrate All reviews are complete 🎯 this sprint This Pull Request is related to a Work Item committed in this sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spelak_sfemu @fwashington_sfemu @sella_sfemu @spelak-salesforce