OTP / 2FA Secret pattern #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babenek
commented
Aug 4, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
=======================================
Coverage ? 92.44%
=======================================
Files ? 138
Lines ? 5570
Branches ? 909
=======================================
Hits ? 5149
Misses ? 269
Partials ? 152 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iuriimet
approved these changes
Aug 5, 2025
Pomidorry
approved these changes
Aug 5, 2025
Collaborator
Pomidorry
left a comment
There was a problem hiding this comment.
Modified tests and rules for OTP / 2FA Secret processing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which is fixed.
Jira 2FArule toOTP / 2FA Secretwith 16/32 symbol patternsHow has this been tested?
Please describe the tests that you ran to verify your changes.