Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Pedantic scan #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
babenek merged 7 commits into from
Sep 15, 2025
Merged

Pedantic scan #756

babenek merged 7 commits into from
Sep 15, 2025

Conversation

@babenek
Copy link
Contributor

@babenek babenek commented Sep 13, 2025 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • Add --pedantic option to scan all files without extension excluding.
  • Add StringsScanner for deep scan to transform a binary like strings linux tool
  • Sort rules only (integrity test added)

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 96.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.46%. Comparing base (3dcf391) to head (9f2aeb2).

Files with missing lines Patch % Lines
credsweeper/deep_scanner/strings_scanner.py 93.75% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
+ Coverage   92.39%   92.46%   +0.07%     
==========================================
  Files         138      139       +1     
  Lines        5572     5617      +45     
  Branches      909      917       +8     
==========================================
+ Hits         5148     5194      +46     
  Misses        272      272              
+ Partials      152      151       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@babenek babenek marked this pull request as ready for review September 13, 2025 10:25
@babenek babenek requested a review from a team as a code owner September 13, 2025 10:25
babenek
babenek commented Sep 15, 2025
View reviewed changes
@babenek babenek merged commit 3c20817 into Samsung:main Sep 15, 2025
23 checks passed
@babenek babenek deleted the pedantic branch September 15, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iuriimet iuriimet iuriimet approved these changes

@404DevVP 404DevVP 404DevVP approved these changes

@xDizzix xDizzix Awaiting requested review from xDizzix

@Yullia Yullia Awaiting requested review from Yullia

@csh519 csh519 Awaiting requested review from csh519

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@babenek @codecov-commenter @iuriimet @404DevVP