Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(scripts): make 'component' flag required #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miltolstoy merged 1 commit into from
Jul 23, 2025
Merged

fix(scripts): make 'component' flag required #12

miltolstoy merged 1 commit into from
Jul 23, 2025

Conversation

@miltolstoy
Copy link
Contributor

@miltolstoy miltolstoy commented Jul 23, 2025

Resolves #6

Before:

$ python3 ./scripts/build.py
'None' component build is unsupported

Now:

$ python3 ./scripts/build.py
usage: Build Java SCP library sources and generate documentation [-h] -c {lib,doc} [-cb]
Build Java SCP library sources and generate documentation: error: the following arguments are required: -c/--component

WhiteHorseKPI
WhiteHorseKPI approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@WhiteHorseKPI WhiteHorseKPI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miltolstoy miltolstoy merged commit 6fec6cb into main Jul 23, 2025
@miltolstoy miltolstoy deleted the 6-component_flag branch July 23, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WhiteHorseKPI WhiteHorseKPI WhiteHorseKPI approved these changes

@Nikolpol Nikolpol Awaiting requested review from Nikolpol Nikolpol is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scripts: make "component" flag mandatory in build script

3 participants

@miltolstoy @WhiteHorseKPI