Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@r-bhalotia
Copy link

No description provided.

"miDebuggerServerAddress": ":1234"
}
]
} No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline before EOF needed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.vscode directory not required. Removed it.

{
String stateMsg = "";

switch (e.State)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be relevant to include the complete set of states (including paused, queued, canceled) to the ones below?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. Added all the states.

Copy link
Contributor

@wootak-jung wootak-jung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patch!
Please review my inline comments.

Copy link

@dr-venkman dr-venkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the commit, please find my comments included.

@SeonahMoon
Copy link
Contributor

The code seems to be well-written overall. I've left a few comments, so please check them.
Also, this app might be exposed externally. How about replacing the office photos with actual screenshots?

@r-bhalotia
Copy link
Author

Thanks for your patch! Please review my inline comments.

Thanks for the review, I have made the required changes.

@r-bhalotia
Copy link
Author

The code seems to be well-written overall. I've left a few comments, so please check them. Also, this app might be exposed externally. How about replacing the office photos with actual screenshots?

Thanks for the review.
Made the required changes and replaced the images with screenshots.

Copy link
Contributor

@SeonahMoon SeonahMoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😃

Copy link

@dr-venkman dr-venkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Contributor

@wootak-jung wootak-jung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants