os/board/rtl8730e: Optimize the CFLAGS length #7035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cff45b9 to
87195cb
Compare
r-prabu
reviewed
Nov 20, 2025
| endif | ||
|
|
||
| # Generate response file containing all CFLAGS | ||
| CFLAGS_FILE := $(TOPDIR)/cflags.rsp |
Collaborator
There was a problem hiding this comment.
The CFLAGS response file approach is a valid solution for addressing command line length limitations. However, the implementation should be carefully integrated with the existing build system to ensure robustness and maintainability. The approach is particularly useful for complex builds with many include paths and definitions.
7f72a54 to
59d4033
Compare
Contributor
seokhun-eom24
left a comment
There was a problem hiding this comment.
Can you seperate commit with Makefile and .gitignore for cherry-pick.
ccbe921 to
92a0bd3
Compare
* Generate a response file containing all the CFLAGS instead of loading an entire CFLAGS string directly. * Remove duplicate include paths to clean up makefile --- Built with before and after modification, MD5 sum of TizenRT/build/output/bin/kernel_rtl8730e_200204.trpk match.
92a0bd3 to
7d0d0b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize the CFLAGS length
Currently, there are many
-Iinclude paths appended toCFLAGS. This may cause the limit of 4096 to exceed.This PR would edit the Makefile to generate a temporary response file containing all the
CFLAGSinstead of loading an entire CFLAGS string directly.Also remove duplicate include paths
CFLAGS += -I$(DIR_OSDEP)CFLAGS += -I$(COMPONENT_DIR)/os_depCFLAGS += -I$(DIR_MBED)CFLAGS += -I$(COMPONENT_DIR)/mbed/targets/hal/rtl8730eCFLAGS += -I$(TOPDIR)/arch/$(CONFIG_ARCH)/src/armv7-aCFLAGS += -I$(TOPDIR)/arch/$(CONFIG_ARCH)/src/armv7-aCFLAGS += -I$(TARGETDIR)/bootloaderCFLAGS += -I$(TARGETDIR)/bootloaderVerification
Built with before and after modification, MD5 sum of
TizenRT/build/output/bin/kernel_rtl8730e_200204.trpkmatch.