-
Notifications
You must be signed in to change notification settings - Fork 619
[Do not merge] framework/src/media, os/audio : Add changeDSPFlow api for change dsp flow rule on real-time. #7064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
100accb to
64cb30f
Compare
…flow rule on real-time. If we apply add_dsp_flow_rules_extract_raw_data using api added, We can extract recording data not preprocessing with AEC.
64cb30f to
c759d06
Compare
aadotverma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are ok
| * It changes the current dsp flow to dsp flow of given number. | ||
| * | ||
| * Input parameter: | ||
| * stream_policy: dwp flow rule number to be changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment
Input parameter:
dsp_flow_num: dsp flow rule number to be changed. 1 for AFE processed data & 2 for raw audio data
| audio_manager_result_t change_input_dsp_flow(uint8_t dsp_flow_num) | ||
| { | ||
| audio_manager_result_t ret; | ||
| struct audio_caps_desc_s caps_desc; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
caps_desc not used anywhere
| } | ||
| auto recorder = std::shared_ptr<WakeRec>(new WakeRec()); | ||
| if (argc == 2 && atoi(argv[1]) == 0) { | ||
| if (atoi(argv[1]) == 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (argc == 3 && atoi(argv[1]) == 0)
| meddbg("SoundManager : changeDSPFlow. dsp_flow_num: %d\n", dsp_flow_num); | ||
| audio_manager_result_t res = change_input_dsp_flow(dsp_flow_num); | ||
| if (res != AUDIO_MANAGER_SUCCESS) { | ||
| meddbg("change_output_dsp_flow failed dsp_flow_num : %d, ret : %d\n", dsp_flow_num, res); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not matching with calling function and msg.
change_output_dsp_flow failed dsp_flow_num -> change_input_dsp_flow failed dsp_flow_num
If we apply add_dsp_flow_rules_extract_raw_data using api added, We can extract recording data not preprocessing with AEC.