introduce safety info + ecs_get_id_from_record & refactor ecs_get_id methods to use it #1752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand why CI for test windows is failing. The test is multithreaded enum registration. could it be a fluke? also see discord, I have some problems with bake. I also don't have a windows PC to further investigate it. Any advice? |
|
ok, seems like some fluke, CI passes |
|
update to latest main + fix conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
performance is unchanged according to the benchmarks, but remarkably sparse components get an unreasonable performance boost. I cannot seem to be able to explain it.
first column is without this commit, second column is with.