Fail on second router #384
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a check when `use_router` is called twice, or `use_router` after `no_router` or the other way around, and fail directly. This is to prohibit setting two routers, which does not have any effect… only the last router is used, which might be confusing. Fixes SaturnFramework#323.
Add a warning in the XML doc about the new throws.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a failure, when
use_routeris called a second time, oruse_routerafterno_router(or the other way around).This is to avoid confusion: When a second (or more) router is added, only the last added router actually does things. An explicit error seems more useful.
Fixes #323.
I am happy to adjust the error messages, btw…