Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: use specialization in NonlinearProblems #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: use specialization in NonlinearProblems #1101

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ea1147
feat: use specialization in NonlinearProblems
avik-pal Oct 29, 2024
8cd8c7f
fix: conditionally remake
avik-pal Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: conditionally remake
  • Loading branch information
@avik-pal
avik-pal committed Oct 29, 2024
commit 8cd8c7f0a2ac0d5ca146c16bbdc4a8ad291f162d
20 changes: 12 additions & 8 deletions src/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1152,20 +1152,24 @@ function get_concrete_problem(prob::NonlinearProblem, isadapt; kwargs...)
p = get_concrete_p(prob, kwargs)
u0 = get_concrete_u0(prob, isadapt, nothing, kwargs)
u0 = promote_u0(u0, p, nothing)
f_promote = promote_f(
prob.f, Val(SciMLBase.specialization(prob.f)), u0, p
)
remake(prob; u0 = u0, p = p, f = f_promote)
f_promote = promote_f(prob.f, Val(SciMLBase.specialization(prob.f)), u0, p)
if f_promote === prob.f && u0 === prob.u0 && p === prob.p
return prob
else
return remake(prob; u0 = u0, p = p, f = f_promote)
end
end

function get_concrete_problem(prob::NonlinearLeastSquaresProblem, isadapt; kwargs...)
p = get_concrete_p(prob, kwargs)
u0 = get_concrete_u0(prob, isadapt, nothing, kwargs)
u0 = promote_u0(u0, p, nothing)
f_promote = promote_f(
prob.f, Val(SciMLBase.specialization(prob.f)), u0, p
)
remake(prob; u0 = u0, p = p, f = f_promote)
f_promote = promote_f(prob.f, Val(SciMLBase.specialization(prob.f)), u0, p)
if f_promote === prob.f && u0 === prob.u0 && p === prob.p
return prob
else
return remake(prob; u0 = u0, p = p, f = f_promote)
end
end

function get_concrete_problem(prob::AbstractEnsembleProblem, isadapt; kwargs...)
Expand Down
Loading