fix: can't implement len for KerasShapesWrapper & Add bias implement to Conv2DTranspose.Call() #1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to Conv2DTranspose.Call()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve 2nd problem of #1012
Before solving the issue, I found another bug in Conv2DTranspose.build(). The len() cannot be used for input_shape after the commit 747e658, which change the type of input_shape from Shape to KerasShapesWrapper. I solved it by using len(single_shape) instead of len(input_shape), where single_shape = input_shape.ToSingleShape().
Back to the issue, the NotImplementedException raised because the lack of implement to handle 'use_bias' in 'Call' process of Conv2DTranspose. I add the code referring original TensorFlow.
Thanks!