Fix boundary flooding when panning axes with a non-data-transform boundary - #2734
Open
greglucas wants to merge 1 commit into
Open
Fix boundary flooding when panning axes with a non-data-transform boundary#2734greglucas wants to merge 1 commit into
greglucas wants to merge 1 commit into
Conversation
…ndary _ViewClippedPathPatch and GeoSpine clipped a custom set_boundary() path against axes.viewLim (data coordinates) unconditionally, even when the path was given in a different transform (e.g. transAxes). Panning far enough made the clip produce an empty path, which disabled clipping and let features flood the whole figure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_ViewClippedPathPatch and GeoSpine clipped a custom set_boundary() path against axes.viewLim (data coordinates) unconditionally, even when the path was given in a different transform (e.g. transAxes). Panning far enough made the clip produce an empty path, which disabled clipping and let features flood the whole figure.
Noticed this while panning around on the example
always_circular_stereo.pyon main where it would invert itself with a flood if you go up and left or down and right far enough.