Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ENH: Deprecation of NetCDF default unlimited dims - #1601

Closed
cpelley wants to merge 3 commits into
SciTools:masterfrom
cpelley:deprecated_unlimited_dims
Closed

ENH: Deprecation of NetCDF default unlimited dims#1601
cpelley wants to merge 3 commits into
SciTools:masterfrom
cpelley:deprecated_unlimited_dims

Conversation

@cpelley

@cpelley cpelley commented Mar 26, 2015

Copy link
Copy Markdown

Closes #1452, replaces #1600

@marqh

marqh commented Mar 26, 2015

Copy link
Copy Markdown
Member

This looks good to go to me.

The behaviour change is one I support, the deprecation warning is in place and the messages are clear.

I recommend this gets merged in time for iris 1.8

rhattersley
rhattersley reviewed Mar 26, 2015
View reviewed changes
Comment thread docs/iris/src/whatsnew/1.8.rst Outdated

@rhattersley rhattersley Mar 26, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't mention that it's for saving netCDF files. (And it doesn't scan particularly well either.)

@cpelley

cpelley commented Mar 26, 2015

Copy link
Copy Markdown
Author

Thanks @rhattersley I'm on it

@cpelley

cpelley commented Mar 26, 2015

Copy link
Copy Markdown
Author

I have pushed up another commit, reflecting the changes requested.

@bjlittle bjlittle mentioned this pull request Mar 26, 2015
Merged
2 tasks
rhattersley
rhattersley reviewed Mar 26, 2015
View reviewed changes
Comment thread lib/iris/fileformats/netcdf.py

@rhattersley rhattersley Mar 26, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine 👍 ... but it also needs to be defined on the top-level save function in this module.

@cpelley

cpelley commented Mar 26, 2015

Copy link
Copy Markdown
Author

I have added both the warning and the added deprecation message to the top level save function as requested. However, I should note that the side effect of this is that we now get two warning messages if we go through netcdf.save.

@rhattersley

rhattersley commented Mar 26, 2015

Copy link
Copy Markdown
Member

I should note that the side effect of this is that we now get two warning messages if we go through netcdf.save.

You can prevent this by having the top-level save function always passing an explicit value to the underlying method.

@cpelley

cpelley commented Mar 26, 2015

Copy link
Copy Markdown
Author

I should note that the side effect of this is that we now get two warning messages if we go through netcdf.save.

You can prevent this by having the top-level save function always passing an explicit value to the underlying method.

Sorry I don't understand, what value to what method?

@cpelley cpelley mentioned this pull request Mar 31, 2015
Closed
@cpelley

cpelley commented Mar 31, 2015

Copy link
Copy Markdown
Author

Since a pre-release has been tagged I'm assuming this has now missed the boat?

@marqh marqh mentioned this pull request Apr 7, 2015
Merged
@bjlittle

bjlittle commented Apr 8, 2015

Copy link
Copy Markdown
Member

Closed by #1607

@bjlittle bjlittle closed this Apr 8, 2015
@cpelley
cpelley deleted the deprecated_unlimited_dims branch April 8, 2015 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cpelley @marqh @rhattersley @bjlittle