Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Whatsnew for v1.11.0 - #2250

Merged
marqh merged 5 commits into
SciTools:v1.11.xfrom
bjlittle:release-docs-1p11
Nov 28, 2016
Merged

Whatsnew for v1.11.0#2250
marqh merged 5 commits into
SciTools:v1.11.xfrom
bjlittle:release-docs-1p11

Conversation

@bjlittle

Copy link
Copy Markdown
Member

Proposed whatsnew for v1.11.0 release.

@bjlittle bjlittle added this to the v1.11 milestone Nov 28, 2016
text = content_object.readlines()
if not text[-1].endswith('\n'):
text[-1] += '\n'
category_text.extend(text)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically fix troublesome contributions with no trailing new line ... otherwise multiple contribution entries are rendered on the same line.

@bjlittle bjlittle Nov 28, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, without this fix in this release we'd end up with the following ...

Iris 1.11 Features
==================
* If available, display the ``STASH`` code instead of ``unknown / (unknown)`` when printing cubes
  with no ``standard_name`` and no ``units``.
* Support for saving to netCDF with data packing has been added.* The coordinate system :class:`iris.coord_systems.LambertAzimuthalEqualArea` has been added with NetCDF saving support.

... instead of this.

@bjlittle

bjlittle commented Nov 28, 2016

Copy link
Copy Markdown
Member Author

Ping @marqh, @dkillick and @ajdawson ... I'm keen to release v1.11 today!

with a scalar masked constant data payload.
* Fixed a bug where :func:`iris.util._is_circular` would erroneously return false
when coordinate values are decreasing.
* When saving to NetCDF, the existing behaviour of writing string attributes as ASCII has been

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very long and quite unusual whatsnew entry. It takes a lot of time to say very little at all, and I'm really not a fan of the unprecedented PR link in the entry. Options...

  • leave it as it is
  • remove it entirely
  • only keep the first sentence of the entry.

I favour the last of those options - it says about the same amount of very little in a single sentence, which at least means we are acknowledging that a change has been made.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm with @dkillick i think that
When saving to NetCDF, the existing behaviour of writing string attributes as ASCII has been maintained across all versions of netCDF4-python

is sufficient information; the rest of the point is a bit lost on me, and I implemented part of the change

I would change all to known as all is an all encompassing term

@marqh

marqh commented Nov 28, 2016

Copy link
Copy Markdown
Member

looks good to go to me, thanks @bjlittle

last call for comments........

@marqh
marqh merged commit 76258cd into SciTools:v1.11.x Nov 28, 2016
@bjlittle
bjlittle deleted the release-docs-1p11 branch November 29, 2016 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants