Line length 88 - #5632
Merged
Merged
Conversation
Member
Author
|
@tkknight This change should help with your |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5632 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 90 90
Lines 22807 22807
Branches 5441 5441
=======================================
Hits 20456 20456
Misses 1618 1618
Partials 733 733 ☔ View full report in Codecov by Sentry. |
bjlittle
force-pushed
the
line-length-88
branch
from
December 12, 2023 21:28
8702227 to
765cab5
Compare
tkknight
approved these changes
Dec 13, 2023
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Dec 13, 2023
* upstream/main: Replace isort with ruff (SciTools#5633) Line length 88 (SciTools#5632)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This pull-request explicitly sets the
line-length = 88(instead of79) forblack,ruffandisort.This brings
irisinto alignment with the defaultline-lengthrecommended byblack.Consult Iris pull request check list